Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Sig Cleanup #158

Open
dustinengle opened this issue Jan 3, 2019 · 0 comments
Open

Multi-Sig Cleanup #158

dustinengle opened this issue Jan 3, 2019 · 0 comments

Comments

@dustinengle
Copy link
Contributor

I believe this could be resolved with some UX improvements, doing some research I can see where the confusion came from.

  1. There's currently no easy way to find a previously generated pay-to-multisig scripts, without knowledge of how P2MS works and it's format to allow a user to manually create it. It would be useful if the multisig dialogue could re-create the ScriptPubKey in addition to the error when creating a address already found inside the wallet. This was the root cause of our issue because I had lost the redeem key and couldn't generate it again to pass it on to @LyGhT1337 .

  2. Being inquisitive, I went online to find a debug console command to try and force the wallet to generate the P2MS redeem again, and stumbled on createmultisig, not knowing much about the topic, this lead me to generating a P2SH redeem which I passed to Lyght. Given that we have the GUI in place, may we want to consider disabling the createmultisig command to prevent any user confusion in the future? Maybe not, but something to consider.

Originally posted by @KaneoHunter in #143 (comment)

@dustinengle dustinengle self-assigned this Jan 3, 2019
@dustinengle dustinengle added this to the 2.2.0.0 milestone Jan 3, 2019
@ghost ghost closed this as completed Jan 6, 2019
@ghost ghost reopened this Jan 6, 2019
@dustinengle dustinengle removed their assignment Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant