Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs/default.json errors #9

Open
philliphall opened this issue Apr 17, 2023 · 0 comments
Open

configs/default.json errors #9

philliphall opened this issue Apr 17, 2023 · 0 comments

Comments

@philliphall
Copy link

New guy here, trying my amateur best to contribute. Happy to be quiet if not helpful...

I built my first config off of configs/default.json from the repo. Unfortunately, it doesn't specify "overrides": "", (among other things), which causes dactyl_manuform.py to error out at line 118:
if data["overrides"] not in [None, ""]:

Noting that src/run_config.json appeard to be much more current, I recommend option 1) EASY - removing default.json, or option 2) PREFERRED - move src/run_config.json to configs/default.json and configure lines 112-114 to pull from that location instead.

Also recommend updating line 118 to if "overrides" in data and data["overrides"] not in [None, ""]: - because if there is any parameter that shouldn't have to be declared, it's overrides :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant