Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php syntax warning #114

Open
ryangroth5 opened this issue Mar 1, 2019 · 1 comment
Open

php syntax warning #114

ryangroth5 opened this issue Mar 1, 2019 · 1 comment

Comments

@ryangroth5
Copy link

getting a syntax error with PHP 7.3.2, "continue is the same as break in a swtich" the following patch suppresses the error and will work for any version of PHP:

--- a/src/PHPVideoToolkit/Mime.php~	2019-02-06 20:11:38.000000000 +0000
+++ b/src/PHPVideoToolkit/Mime.php	2019-03-01 15:57:29.245315100 +0000
@@ -186,7 +186,7 @@
 
                          default:
                             // date, ldate, ledate, leldate, beldate, lebelbe...
-                            continue;
+                            break;
                       }
                    }
                
@blue-eyed-devil
Copy link

blue-eyed-devil commented Apr 9, 2019

have same with php 7.3.3 but only if resizing from small to larger video:

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/vendor/buggedcom/phpvideotoolkit/src/PHPVideoToolkit/Mime.php on line 189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants