Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V-Cut Layer Edge.Cuts #7

Open
dartrax opened this issue Jan 26, 2025 · 9 comments
Open

V-Cut Layer Edge.Cuts #7

dartrax opened this issue Jan 26, 2025 · 9 comments

Comments

@dartrax
Copy link

dartrax commented Jan 26, 2025

Hi,
this is a very helpful application, thank you for this!
For JLCPCB, I need the V-Cuts on the Edge.Cuts-Layer. Could you please add this option to the combo box?
Thank you!

@buganini
Copy link
Owner

While it is easy to add that, in my experience I don't have to put V-Cut at edge cut layer.

Please check this
https://www.reddit.com/r/KiCad/s/rS9DUkS0Tx

@buganini
Copy link
Owner

And just FYI, JLCPCB doesn't do V-cut for panel with economic SMT order in my previous experience.

@dartrax
Copy link
Author

dartrax commented Jan 26, 2025

Thanks for the hint, but I need to use parts that require standard SMT service.

While I agree that it might work with other layers, too, I'm sure some people would prefer to stick to jlcpcb's official requirements when it's easy to implement ;-)

@buganini
Copy link
Owner

I just checked, Bouni/kicad-jlcpcb-tools output v-cuts to a VScore layer
Image
I would say it is safe to use vscore layer, people has been using for years
https://www.reddit.com/r/PrintedCircuitBoard/comments/a9mgfk/comment/eckp6k4/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

And last time I sent gerber files with vscore layer without any notes, JLCPCB did recognized that

Image

I actually shouldn't add the edge cut layer, if it is placed in edge cut layer in .kicad_pcb, KiCad cannot correctly calculate board shape.
Image

@dartrax
Copy link
Author

dartrax commented Jan 26, 2025

Oh, I also use the Bouni/kicad-jlcpcb-tools. So, what would be the correct setting to work with JLCPCB Tools?

@buganini
Copy link
Owner

I used default "Cmts.User" with Bouni/kicad-jlcpcb-tools.

@buganini
Copy link
Owner

I still added the edge.cuts as an option.

@dartrax
Copy link
Author

dartrax commented Jan 26, 2025

Thank you :-)

Btw, line 636 and 638 looking duplicated, not sure if it is correct.

panel.vCutSettings.layer = {
            "Edge.Cuts": Layer.Edge_Cuts,
            "User.1": Layer.User_1,
            "Edge.Cuts": Layer.Edge_Cuts,
        }.get(self.state.vc_layer, Layer.Cmts_User)

@buganini
Copy link
Owner

it's fixed in 9e53e8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants