v1.2.1 missed pre-built binaries #1234
Comments
|
Looks like there is some race condition somewhere because it worked for 1.2.0. Would suggest upgrading to that for now. 1.2.1 was only to fix Python build. |
nicksnyder
added a commit
that referenced
this issue
Jan 23, 2025
The goal of this change is to fix the symptoms described in the following two issues: - #1234 - #1059 It seems the goreleaser action that was triggered by the 1.2.1 tag thought that the current tag was 1.2.1.SNAPSHOT.0 ``` git state commit=7b06248484ceeaa947e93ca2747eccf336a88ecc branch=HEAD current_tag=v1.2.1-SNAPSHOT.0 previous_tag=v1.2.0 ``` Source: https://github.com/bufbuild/protoc-gen-validate/actions/runs/12916704001/job/36021453853#step:5:21 Basically we ended up with two tags pointing at the same commit and goreleaser picked one: goreleaser/goreleaser#4134 We were unnecessarily increasing the likelihood of that happening by force fetching all tags (which is unnecessary because we will already have the intended tag fetched that triggered the push), so I removed that step here: 87dc0be Additionally, I don't think there is any value in having snapshot tags at all so I deleted the entire version bump workflow here: 79a4a4f Furthermore, we had goreleaser configured to publish drafts, which doesn't make sense if we want to initiate release from the GitHub UI (which I think we do and is similer/easier) so I deleted all the extra config here: 56f26d0 The default config is the right thing for us. Finally there were some settings in setup-go we had configured that have no effect now, so I removed them: 33528d7
|
After diagnosing the issue and rerunning the job, 1.2.1 has assets now. I believe that #1235 will resolve the flakiness moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/bufbuild/protoc-gen-validate/releases/tag/v1.2.1
GoReleaser succeeded.
https://github.com/bufbuild/protoc-gen-validate/actions/runs/12916704001/job/36021453853
Look like a draft release?
But the workflow run was triggered by push tag event. 🤔
https://github.com/bufbuild/protoc-gen-validate/actions/runs/12916704001
The text was updated successfully, but these errors were encountered: