Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify windows status of windows support #184

Closed
mostynb opened this issue Feb 7, 2020 · 0 comments
Closed

clarify windows status of windows support #184

mostynb opened this issue Feb 7, 2020 · 0 comments

Comments

@mostynb
Copy link
Collaborator

mostynb commented Feb 7, 2020

While bazel-remote is known to work on both linux and macos, the status on windows is unclear.

By default windows does not allow the removal of files open in another process. There is a FILE_SHARE_DELETE flag that can be used to make this behave a bit more like POSIX, but with some subtle differences. It is not clear from the documentation if a single process (like bazel-remote) can remove a file in one goroutine while it's open in another goroutine on windows.

It would be good to test these scenarios:

  1. A blob can have in-progress downloads when it reaches the end of the LRU and is evicted, triggering a file removal.
  2. A blob can have in-progress downloads when it is replaced by an upload for the same key.

There is some discussion on this topic in golang/go#32088 (comment) and golang/go#34681 (comment)
@mostynb mostynb mentioned this issue Feb 7, 2020
Merged
mostynb added a commit to mostynb/bazel-remote that referenced this issue May 27, 2020
@mostynb
prevent from building for windows
d596cff 
bazel-remote does not work on windows, due to the way we interact with
the filesystem. Let's prevent windows builds from succeeding, to avoid
wasting windows users' time trying.

Background: buchgr#184
@mostynb mostynb mentioned this issue May 27, 2020
Merged
mostynb added a commit to mostynb/bazel-remote that referenced this issue May 28, 2020
@mostynb
prevent building for windows
ed4dff1 
bazel-remote does not work on windows, due to the way we interact with
the filesystem. Let's prevent windows builds from succeeding, to avoid
wasting windows users' time trying.

Background: buchgr#184
mostynb added a commit that referenced this issue May 28, 2020
@mostynb
prevent building for windows
840f14a 
bazel-remote does not work on windows, due to the way we interact with
the filesystem. Let's prevent windows builds from succeeding, to avoid
wasting windows users' time trying.

Background: #184
@mostynb mostynb closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mostynb