Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver matching function is matching on pre-release tags when it should skip those #32

Open
pharr117 opened this issue Nov 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pharr117
Copy link
Collaborator

pharr117 commented Nov 2, 2023

The find_best_semver_for_versions function seems to be matching on pre-release tags.

User reports say that the persistence network was reporting the following info before their upgrade today:

{
  "type": "mainnet",
  "network": "persistence",
  "rpc_server": "https://rpc-persistence.architectnodes.com/",
  "rest_server": "https://api-persistence.cosmos-spaces.cloud/",
  "latest_block_height": 13870121,
  "upgrade_found": true,
  "upgrade_name": "v10",
  "source": "current_upgrade_plan",
  "upgrade_block_height": 13870350,
  "estimated_upgrade_time": "2023-11-02T14:34:22.177132",
  "upgrade_plan": {
    "height": 13870350,
    "binaries": [],
    "name": "v10",
    "upgraded_client_state": null
  },
  "version": "v10.1.0",
  "error": null
}

Notice v10.1.0. This was found in a pre-release tag:

image

We need to fix the find_best_semver_for_versions so it skips prerelease tags.

@pharr117 pharr117 added the bug Something isn't working label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant