local.js crashes process if binarypath option is specified and there's an error launching proxy

[rwproctor]

The start function in the local.js code will attempt to unlink and delete the executable and then re-download a new version of the proxy even if a binarypath is specified. If a binarypath is specified, then the caller is indicating that they do not want to run off a downloaded (and potentially newer version) of the proxy and hence the binary should not be deleted. In our case on Windows, the unlink operation causes an EPERM error that causes the process to exit.

Expected Behavior

If a binaryPath is specified, then the code should not try to unlink or delete it.

Actual Behavior

The code is attempting to delete it which could cause an error.

Steps to Reproduce the Problem

1. Specify a binarypath for the proxy executable
2. Force the launch of the proxy to fail (bad key or no network)

browserstack local arguments

{ 'key': '', 'forceLocal': 'true', 'binarypath': config.proxyPath, 'local-identifier': 'UNK', 'logfile': 'proxy.log', 'parallel-runs': 2, 'verbose': '1', 'use-ca-certificate': 'certs.pem', 'exclude-hosts': '.*\.gvt1.com .*\.apple.com .*\.google.com .*\.cloudfront.net .*\.googleapis.com .*\.microsoft.com .*\.digicert.com .*\.cloudfront.net .*\.cloudfront.com' };

Platform details

1. browserstack-local-nodejs version: [email protected]
2. node version: v14.15.1
3. os type and version: Windows NT 6.2

Details

This is causing our server that manages proxies for 14 teams on this server to crash whenever there is an issue connecting to the browserstack server. We recycle our keys frequently for security reasons and everytime the keys get recycled we must restart the proxies. Here's a sample of the issue occurring.

The suggested code fix in local.js would be...

[bipul21]

We are looking into this.

[SDETQATestAutomation]

Any Update on this issue, i am getting same error.