From 18b556f094dc66c52a6ab2982dc76b3cc04a9443 Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Tue, 9 Jul 2024 17:28:12 +0530 Subject: [PATCH 1/9] Moved heading-order to experimental --- lib/rules/heading-order.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/heading-order.json b/lib/rules/heading-order.json index 843a291ec..a6a10042c 100644 --- a/lib/rules/heading-order.json +++ b/lib/rules/heading-order.json @@ -3,7 +3,7 @@ "impact": "moderate", "selector": "h1, h2, h3, h4, h5, h6, [role=heading]", "matches": "heading-matches", - "tags": ["cat.semantics", "best-practice"], + "tags": ["cat.semantics", "wcag2aaa", "wcag2410", "experimental"], "metadata": { "description": "Ensures the order of headings is semantically correct", "help": "Heading levels should only increase by one" From 4ed487973d6221054d137f3d154c2f8cd3058972 Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Tue, 9 Jul 2024 17:29:23 +0530 Subject: [PATCH 2/9] Moved heading-order to experimental --- doc/rule-descriptions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index b89eddab7..ea55ef8e4 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -104,7 +104,6 @@ Rules that do not necessarily conform to WCAG success criterion but are industry | [empty-heading](https://dequeuniversity.com/rules/axe/4.9/empty-heading?application=RuleDescription) | Ensures headings have discernible text | Minor | cat.name-role-value, best-practice | failure, needs review | [ffd0e9](https://act-rules.github.io/rules/ffd0e9) | | [empty-table-header](https://dequeuniversity.com/rules/axe/4.9/empty-table-header?application=RuleDescription) | Ensures table headers have discernible text | Minor | cat.name-role-value, best-practice | failure, needs review | | | [frame-tested](https://dequeuniversity.com/rules/axe/4.9/frame-tested?application=RuleDescription) | Ensures <iframe> and <frame> elements contain the axe-core script | Critical | cat.structure, best-practice, review-item | failure, needs review | | -| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.semantics, best-practice | failure, needs review | | | [image-redundant-alt](https://dequeuniversity.com/rules/axe/4.9/image-redundant-alt?application=RuleDescription) | Ensure image alternative is not repeated as text | Minor | cat.text-alternatives, best-practice | failure | | | [label-title-only](https://dequeuniversity.com/rules/axe/4.9/label-title-only?application=RuleDescription) | Ensures that every form element has a visible label and is not solely labeled using hidden labels, or the title or aria-describedby attributes | Serious | cat.forms, best-practice | failure | | | [landmark-banner-is-top-level](https://dequeuniversity.com/rules/axe/4.9/landmark-banner-is-top-level?application=RuleDescription) | Ensures the banner landmark is at top level | Moderate | cat.semantics, best-practice | failure | | @@ -143,6 +142,7 @@ Rules we are still testing and developing. They are disabled by default in axe-c | :------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------- | :------- | :----------------------------------------------------------------------------------------------------------- | :------------------------- | :------------------------------------------------- | | [css-orientation-lock](https://dequeuniversity.com/rules/axe/4.9/css-orientation-lock?application=RuleDescription) | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious | cat.structure, wcag134, wcag21aa, EN-301-549, EN-9.1.3.4, experimental | failure, needs review | [b33eff](https://act-rules.github.io/rules/b33eff) | | [focus-order-semantics](https://dequeuniversity.com/rules/axe/4.9/focus-order-semantics?application=RuleDescription) | Ensures elements in the focus order have a role appropriate for interactive content | Minor | cat.keyboard, best-practice, experimental | failure | | +| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.semantics, wcag2aaa, wcag2410, experimental | failure, needs review | | | [hidden-content](https://dequeuniversity.com/rules/axe/4.9/hidden-content?application=RuleDescription) | Informs users about hidden content. | Minor | cat.structure, best-practice, experimental, review-item | failure, needs review | | | [label-content-name-mismatch](https://dequeuniversity.com/rules/axe/4.9/label-content-name-mismatch?application=RuleDescription) | Ensures that elements labelled through their content must have their visible text as part of their accessible name | Serious | cat.semantics, wcag21a, wcag253, EN-301-549, EN-9.2.5.3, experimental | failure | [2ee8b8](https://act-rules.github.io/rules/2ee8b8) | | [p-as-heading](https://dequeuniversity.com/rules/axe/4.9/p-as-heading?application=RuleDescription) | Ensure bold, italic text and font-size is not used to style <p> elements as a heading | Serious | cat.semantics, wcag2a, wcag131, EN-301-549, EN-9.1.3.1, experimental | failure, needs review | | From 12708bd0d1e0efcd11f2f670ac52c6b720b69467 Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Wed, 10 Jul 2024 16:49:16 +0530 Subject: [PATCH 3/9] Moved heading-order to experimental --- lib/rules/heading-order.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/rules/heading-order.json b/lib/rules/heading-order.json index a6a10042c..e4c94c6c9 100644 --- a/lib/rules/heading-order.json +++ b/lib/rules/heading-order.json @@ -3,7 +3,13 @@ "impact": "moderate", "selector": "h1, h2, h3, h4, h5, h6, [role=heading]", "matches": "heading-matches", - "tags": ["cat.semantics", "wcag2aaa", "wcag2410", "experimental"], + "tags": [ + "cat.semantics", + "wcag2aaa", + "wcag2410", + "a11y-engine", + "a11y-engine-experimental" + ], "metadata": { "description": "Ensures the order of headings is semantically correct", "help": "Heading levels should only increase by one" From 16d7ac24bffe02cd5972851153f3ca85e92ecdb3 Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Wed, 10 Jul 2024 16:53:00 +0530 Subject: [PATCH 4/9] heading-order description fix --- doc/rule-descriptions.md | 12 ++++++------ lib/rules/heading-order.json | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index ea55ef8e4..dd24da120 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -128,11 +128,12 @@ Rules that do not necessarily conform to WCAG success criterion but are industry Rules that check for conformance to WCAG AAA success criteria that can be fully automated. These are disabled by default in axe-core. -| Rule ID | Description | Impact | Tags | Issue Type | ACT Rules | -| :--------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------- | :------ | :--------------------------------------------- | :------------------------- | :------------------------------------------------- | -| [color-contrast-enhanced](https://dequeuniversity.com/rules/axe/4.9/color-contrast-enhanced?application=RuleDescription) | Ensures the contrast between foreground and background colors meets WCAG 2 AAA enhanced contrast ratio thresholds | Serious | cat.color, wcag2aaa, wcag146, ACT | failure, needs review | [09o5cg](https://act-rules.github.io/rules/09o5cg) | -| [identical-links-same-purpose](https://dequeuniversity.com/rules/axe/4.9/identical-links-same-purpose?application=RuleDescription) | Ensure that links with the same accessible name serve a similar purpose | Minor | cat.semantics, wcag2aaa, wcag249 | needs review | [b20e66](https://act-rules.github.io/rules/b20e66) | -| [meta-refresh-no-exceptions](https://dequeuniversity.com/rules/axe/4.9/meta-refresh-no-exceptions?application=RuleDescription) | Ensures <meta http-equiv="refresh"> is not used for delayed refresh | Minor | cat.time-and-media, wcag2aaa, wcag224, wcag325 | failure | [bisz58](https://act-rules.github.io/rules/bisz58) | +| Rule ID | Description | Impact | Tags | Issue Type | ACT Rules | +| :--------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------- | :------- | :----------------------------------------------------------------------- | :------------------------- | :------------------------------------------------- | +| [color-contrast-enhanced](https://dequeuniversity.com/rules/axe/4.9/color-contrast-enhanced?application=RuleDescription) | Ensures the contrast between foreground and background colors meets WCAG 2 AAA enhanced contrast ratio thresholds | Serious | cat.color, wcag2aaa, wcag146, ACT | failure, needs review | [09o5cg](https://act-rules.github.io/rules/09o5cg) | +| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.semantics, wcag2aaa, wcag2410, a11y-engine, a11y-engine-experimental | failure, needs review | | +| [identical-links-same-purpose](https://dequeuniversity.com/rules/axe/4.9/identical-links-same-purpose?application=RuleDescription) | Ensure that links with the same accessible name serve a similar purpose | Minor | cat.semantics, wcag2aaa, wcag249 | needs review | [b20e66](https://act-rules.github.io/rules/b20e66) | +| [meta-refresh-no-exceptions](https://dequeuniversity.com/rules/axe/4.9/meta-refresh-no-exceptions?application=RuleDescription) | Ensures <meta http-equiv="refresh"> is not used for delayed refresh | Minor | cat.time-and-media, wcag2aaa, wcag224, wcag325 | failure | [bisz58](https://act-rules.github.io/rules/bisz58) | ## Experimental Rules @@ -142,7 +143,6 @@ Rules we are still testing and developing. They are disabled by default in axe-c | :------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------- | :------- | :----------------------------------------------------------------------------------------------------------- | :------------------------- | :------------------------------------------------- | | [css-orientation-lock](https://dequeuniversity.com/rules/axe/4.9/css-orientation-lock?application=RuleDescription) | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious | cat.structure, wcag134, wcag21aa, EN-301-549, EN-9.1.3.4, experimental | failure, needs review | [b33eff](https://act-rules.github.io/rules/b33eff) | | [focus-order-semantics](https://dequeuniversity.com/rules/axe/4.9/focus-order-semantics?application=RuleDescription) | Ensures elements in the focus order have a role appropriate for interactive content | Minor | cat.keyboard, best-practice, experimental | failure | | -| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.semantics, wcag2aaa, wcag2410, experimental | failure, needs review | | | [hidden-content](https://dequeuniversity.com/rules/axe/4.9/hidden-content?application=RuleDescription) | Informs users about hidden content. | Minor | cat.structure, best-practice, experimental, review-item | failure, needs review | | | [label-content-name-mismatch](https://dequeuniversity.com/rules/axe/4.9/label-content-name-mismatch?application=RuleDescription) | Ensures that elements labelled through their content must have their visible text as part of their accessible name | Serious | cat.semantics, wcag21a, wcag253, EN-301-549, EN-9.2.5.3, experimental | failure | [2ee8b8](https://act-rules.github.io/rules/2ee8b8) | | [p-as-heading](https://dequeuniversity.com/rules/axe/4.9/p-as-heading?application=RuleDescription) | Ensure bold, italic text and font-size is not used to style <p> elements as a heading | Serious | cat.semantics, wcag2a, wcag131, EN-301-549, EN-9.1.3.1, experimental | failure, needs review | | diff --git a/lib/rules/heading-order.json b/lib/rules/heading-order.json index e4c94c6c9..34adad597 100644 --- a/lib/rules/heading-order.json +++ b/lib/rules/heading-order.json @@ -12,7 +12,7 @@ ], "metadata": { "description": "Ensures the order of headings is semantically correct", - "help": "Heading levels should only increase by one" + "help": "Heading levels must increase by one" }, "all": [], "any": ["heading-order"], From 92241b07ea547975e2962d687421c598311cc540 Mon Sep 17 00:00:00 2001 From: Abhishek Bindra Date: Thu, 11 Jul 2024 15:10:23 +0530 Subject: [PATCH 5/9] add a new category: images --- build/tasks/validate.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build/tasks/validate.js b/build/tasks/validate.js index 58dd534b8..2f96adc92 100644 --- a/build/tasks/validate.js +++ b/build/tasks/validate.js @@ -330,7 +330,8 @@ const categories = [ 'structure', 'tables', 'text-alternatives', - 'time-and-media' + 'time-and-media', + 'images' ]; const standardsTags = [ From 284cd2c002c3282b282cf5f0ec3604bb81414456 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 16 Jul 2024 04:02:52 +0000 Subject: [PATCH 6/9] chore: bump ws, engine.io and socket.io-adapter Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/engine.io) and [socket.io-adapter](https://github.com/socketio/socket.io-adapter). These dependencies needed to be updated together. Updates `ws` from 8.16.0 to 8.18.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/8.16.0...8.18.0) Updates `engine.io` from 6.5.4 to 6.5.5 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/6.5.5/CHANGELOG.md) - [Commits](https://github.com/socketio/engine.io/compare/6.5.4...6.5.5) Updates `socket.io-adapter` from 2.5.4 to 2.5.5 - [Release notes](https://github.com/socketio/socket.io-adapter/releases) - [Changelog](https://github.com/socketio/socket.io-adapter/blob/2.5.5/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io-adapter/compare/2.5.4...2.5.5) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: engine.io dependency-type: indirect - dependency-name: socket.io-adapter dependency-type: indirect ... Signed-off-by: dependabot[bot] --- package-lock.json | 74 +++++++++++++++++++++++------------------------ 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/package-lock.json b/package-lock.json index cfd8fddfd..b983f73d2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "browser-driver-manager": "1.0.4", "chai": "^4.3.7", "chalk": "^4.x", - "chromedriver": "latest", + "chromedriver": "*", "clean-jsdoc-theme": "^4.2.17", "clone": "^2.1.2", "colorjs.io": "^0.5.0", @@ -4935,9 +4935,9 @@ } }, "node_modules/engine.io": { - "version": "6.5.4", - "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.4.tgz", - "integrity": "sha512-KdVSDKhVKyOi+r5uEabrDLZw2qXStVvCsEB/LN3mw4WFi6Gx50jTyuxYVCwAAC0U46FdnzP/ScKRBTXb/NiEOg==", + "version": "6.5.5", + "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.5.tgz", + "integrity": "sha512-C5Pn8Wk+1vKBoHghJODM63yk8MvrO9EWZUfkAt5HAqIgPE4/8FF0PEGHXtEd40l223+cE5ABWuPzm38PHFXfMA==", "dev": true, "dependencies": { "@types/cookie": "^0.4.1", @@ -4949,7 +4949,7 @@ "cors": "~2.8.5", "debug": "~4.3.1", "engine.io-parser": "~5.2.1", - "ws": "~8.11.0" + "ws": "~8.17.1" }, "engines": { "node": ">=10.2.0" @@ -4965,16 +4965,16 @@ } }, "node_modules/engine.io/node_modules/ws": { - "version": "8.11.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.11.0.tgz", - "integrity": "sha512-HPG3wQd9sNQoT9xHyNCXoDUa+Xw/VevmY9FoHyQ+g+rrMn4j6FB4np7Z0OhdTgjx6MgQLK7jwSy1YecU1+4Asg==", + "version": "8.17.1", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz", + "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==", "dev": true, "engines": { "node": ">=10.0.0" }, "peerDependencies": { "bufferutil": "^4.0.1", - "utf-8-validate": "^5.0.2" + "utf-8-validate": ">=5.0.2" }, "peerDependenciesMeta": { "bufferutil": { @@ -11565,26 +11565,26 @@ } }, "node_modules/socket.io-adapter": { - "version": "2.5.4", - "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.4.tgz", - "integrity": "sha512-wDNHGXGewWAjQPt3pyeYBtpWSq9cLE5UW1ZUPL/2eGK9jtse/FpXib7epSTsz0Q0m+6sg6Y4KtcFTlah1bdOVg==", + "version": "2.5.5", + "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.5.tgz", + "integrity": "sha512-eLDQas5dzPgOWCk9GuuJC2lBqItuhKI4uxGgo9aIV7MYbk2h9Q6uULEh8WBzThoI7l+qU9Ast9fVUmkqPP9wYg==", "dev": true, "dependencies": { "debug": "~4.3.4", - "ws": "~8.11.0" + "ws": "~8.17.1" } }, "node_modules/socket.io-adapter/node_modules/ws": { - "version": "8.11.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.11.0.tgz", - "integrity": "sha512-HPG3wQd9sNQoT9xHyNCXoDUa+Xw/VevmY9FoHyQ+g+rrMn4j6FB4np7Z0OhdTgjx6MgQLK7jwSy1YecU1+4Asg==", + "version": "8.17.1", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz", + "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==", "dev": true, "engines": { "node": ">=10.0.0" }, "peerDependencies": { "bufferutil": "^4.0.1", - "utf-8-validate": "^5.0.2" + "utf-8-validate": ">=5.0.2" }, "peerDependenciesMeta": { "bufferutil": { @@ -13061,9 +13061,9 @@ "dev": true }, "node_modules/ws": { - "version": "8.16.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.16.0.tgz", - "integrity": "sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==", + "version": "8.18.0", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.18.0.tgz", + "integrity": "sha512-8VbfWfHLbbwu3+N6OKsOMpBdT4kXPDDB9cJk2bJ6mh9ucxdlnNvH1e+roYkKmN9Nxw2yjz7VzeO9oOz2zJ04Pw==", "dev": true, "engines": { "node": ">=10.0.0" @@ -16889,9 +16889,9 @@ } }, "engine.io": { - "version": "6.5.4", - "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.4.tgz", - "integrity": "sha512-KdVSDKhVKyOi+r5uEabrDLZw2qXStVvCsEB/LN3mw4WFi6Gx50jTyuxYVCwAAC0U46FdnzP/ScKRBTXb/NiEOg==", + "version": "6.5.5", + "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.5.tgz", + "integrity": "sha512-C5Pn8Wk+1vKBoHghJODM63yk8MvrO9EWZUfkAt5HAqIgPE4/8FF0PEGHXtEd40l223+cE5ABWuPzm38PHFXfMA==", "dev": true, "requires": { "@types/cookie": "^0.4.1", @@ -16903,13 +16903,13 @@ "cors": "~2.8.5", "debug": "~4.3.1", "engine.io-parser": "~5.2.1", - "ws": "~8.11.0" + "ws": "~8.17.1" }, "dependencies": { "ws": { - "version": "8.11.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.11.0.tgz", - "integrity": "sha512-HPG3wQd9sNQoT9xHyNCXoDUa+Xw/VevmY9FoHyQ+g+rrMn4j6FB4np7Z0OhdTgjx6MgQLK7jwSy1YecU1+4Asg==", + "version": "8.17.1", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz", + "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==", "dev": true, "requires": {} } @@ -21864,19 +21864,19 @@ } }, "socket.io-adapter": { - "version": "2.5.4", - "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.4.tgz", - "integrity": "sha512-wDNHGXGewWAjQPt3pyeYBtpWSq9cLE5UW1ZUPL/2eGK9jtse/FpXib7epSTsz0Q0m+6sg6Y4KtcFTlah1bdOVg==", + "version": "2.5.5", + "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.5.tgz", + "integrity": "sha512-eLDQas5dzPgOWCk9GuuJC2lBqItuhKI4uxGgo9aIV7MYbk2h9Q6uULEh8WBzThoI7l+qU9Ast9fVUmkqPP9wYg==", "dev": true, "requires": { "debug": "~4.3.4", - "ws": "~8.11.0" + "ws": "~8.17.1" }, "dependencies": { "ws": { - "version": "8.11.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.11.0.tgz", - "integrity": "sha512-HPG3wQd9sNQoT9xHyNCXoDUa+Xw/VevmY9FoHyQ+g+rrMn4j6FB4np7Z0OhdTgjx6MgQLK7jwSy1YecU1+4Asg==", + "version": "8.17.1", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz", + "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==", "dev": true, "requires": {} } @@ -23003,9 +23003,9 @@ "dev": true }, "ws": { - "version": "8.16.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.16.0.tgz", - "integrity": "sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==", + "version": "8.18.0", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.18.0.tgz", + "integrity": "sha512-8VbfWfHLbbwu3+N6OKsOMpBdT4kXPDDB9cJk2bJ6mh9ucxdlnNvH1e+roYkKmN9Nxw2yjz7VzeO9oOz2zJ04Pw==", "dev": true, "requires": {} }, From 9dbe5ae45547605c185a9ed4efc41aa601c7f2ce Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Thu, 18 Jul 2024 14:41:09 +0530 Subject: [PATCH 7/9] Updated how to fix for heading order --- lib/checks/navigation/heading-order.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/checks/navigation/heading-order.json b/lib/checks/navigation/heading-order.json index e65866ff7..bfdd8c862 100644 --- a/lib/checks/navigation/heading-order.json +++ b/lib/checks/navigation/heading-order.json @@ -7,7 +7,7 @@ "messages": { "pass": "Heading order valid", "fail": "Heading order invalid", - "incomplete": "Unable to determine previous heading" + "incomplete": "Fix the order of headings. Headings should be in descending order of size without skipping levels. For example,

should be followed by

, not

or

." } } } From 63dbb3945a553fb722c6b4e6154298f22d0ca735 Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Wed, 24 Jul 2024 15:39:00 +0530 Subject: [PATCH 8/9] Updated the tags --- lib/rules/heading-order.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/heading-order.json b/lib/rules/heading-order.json index 34adad597..3c34729bf 100644 --- a/lib/rules/heading-order.json +++ b/lib/rules/heading-order.json @@ -4,7 +4,7 @@ "selector": "h1, h2, h3, h4, h5, h6, [role=heading]", "matches": "heading-matches", "tags": [ - "cat.semantics", + "cat.structure", "wcag2aaa", "wcag2410", "a11y-engine", From 48f877b6d8bc7c455c68bcbea6e8de82b1e5639f Mon Sep 17 00:00:00 2001 From: Utkarsh Chaudhary Date: Wed, 24 Jul 2024 17:39:16 +0530 Subject: [PATCH 9/9] Updated the tags --- doc/rule-descriptions.md | 2 +- lib/checks/navigation/heading-order.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md index dd24da120..0f0b12ffd 100644 --- a/doc/rule-descriptions.md +++ b/doc/rule-descriptions.md @@ -131,7 +131,7 @@ Rules that check for conformance to WCAG AAA success criteria that can be fully | Rule ID | Description | Impact | Tags | Issue Type | ACT Rules | | :--------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------- | :------- | :----------------------------------------------------------------------- | :------------------------- | :------------------------------------------------- | | [color-contrast-enhanced](https://dequeuniversity.com/rules/axe/4.9/color-contrast-enhanced?application=RuleDescription) | Ensures the contrast between foreground and background colors meets WCAG 2 AAA enhanced contrast ratio thresholds | Serious | cat.color, wcag2aaa, wcag146, ACT | failure, needs review | [09o5cg](https://act-rules.github.io/rules/09o5cg) | -| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.semantics, wcag2aaa, wcag2410, a11y-engine, a11y-engine-experimental | failure, needs review | | +| [heading-order](https://dequeuniversity.com/rules/axe/4.9/heading-order?application=RuleDescription) | Ensures the order of headings is semantically correct | Moderate | cat.structure, wcag2aaa, wcag2410, a11y-engine, a11y-engine-experimental | failure, needs review | | | [identical-links-same-purpose](https://dequeuniversity.com/rules/axe/4.9/identical-links-same-purpose?application=RuleDescription) | Ensure that links with the same accessible name serve a similar purpose | Minor | cat.semantics, wcag2aaa, wcag249 | needs review | [b20e66](https://act-rules.github.io/rules/b20e66) | | [meta-refresh-no-exceptions](https://dequeuniversity.com/rules/axe/4.9/meta-refresh-no-exceptions?application=RuleDescription) | Ensures <meta http-equiv="refresh"> is not used for delayed refresh | Minor | cat.time-and-media, wcag2aaa, wcag224, wcag325 | failure | [bisz58](https://act-rules.github.io/rules/bisz58) | diff --git a/lib/checks/navigation/heading-order.json b/lib/checks/navigation/heading-order.json index bfdd8c862..70a786cb5 100644 --- a/lib/checks/navigation/heading-order.json +++ b/lib/checks/navigation/heading-order.json @@ -6,8 +6,8 @@ "impact": "moderate", "messages": { "pass": "Heading order valid", - "fail": "Heading order invalid", - "incomplete": "Fix the order of headings. Headings should be in descending order of size without skipping levels. For example,

should be followed by

, not

or

." + "fail": "Fix the order of headings. Headings should be in descending order of size without skipping levels. For example,

should be followed by

, not

or

.", + "incomplete": "Unable to determine previous heading" } } }