From 95b610a45d6f30902a08d678202540e898e6671e Mon Sep 17 00:00:00 2001
From: "Michael S. Noble" <mnoble@broadinstitute.org>
Date: Fri, 9 Feb 2018 15:06:47 -0500
Subject: [PATCH] v0.16.10: hotfix for robust deployment on Google AppEngine

---
 changelog.txt       | 2 ++
 firecloud/fccore.py | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/changelog.txt b/changelog.txt
index b7d27ef..86d9c91 100644
--- a/changelog.txt
+++ b/changelog.txt
@@ -2,6 +2,8 @@
 Change Log for FISSFC: the (Fi)recloud (S)ervice (S)elector
 =======================================================================
 Terms used below:  HL = high level interface, LL = low level interface
+v0.16.9 -  Hotfix; modified how subprocess.call() is utilized to avoid
+           problems on Google AppEngine, where it is prohibited
 v0.16.8 -  Hotfix; entity_import corrected to only strip newline characters.
 
 v0.16.7 -  Enabled LL and HL access to the linkExistingEntities field of the
diff --git a/firecloud/fccore.py b/firecloud/fccore.py
index 762cc3d..e6dcb9a 100644
--- a/firecloud/fccore.py
+++ b/firecloud/fccore.py
@@ -21,7 +21,7 @@
 import tempfile
 import shutil
 from collections import Iterable
-from subprocess import call
+import subprocess
 from io import IOBase
 from firecloud import __about__
 from google.auth import environment_vars
@@ -193,7 +193,7 @@ def edit_text(text=None):
     if text:
         tf.write(text)
         tf.flush()
-    call([__EDITOR__, tf.name])
+    subprocess.call([__EDITOR__, tf.name])
     with open(tf.name, 'r') as newfile:
         text = newfile.read()
     tf.close()
@@ -211,7 +211,7 @@ def edit_file(name, backup=None):
         shutil.copy2(name, backup)
     # Record time of last modification: tolm
     previous_tolm = os.stat(name).st_mtime
-    call([__EDITOR__, name])
+    subprocess.call([__EDITOR__, name])
     current_tolm  = os.stat(name).st_mtime
     return current_tolm != previous_tolm