Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inappropriate hard-coded constant const.MAX_TOTAL_DROPLETS_GUESSED for large datasets? #390

Open
colobas opened this issue Oct 23, 2024 · 0 comments

Comments

@colobas
Copy link

colobas commented Oct 23, 2024

While running cellbender on a large dataset, I kept running into problems similar to what's described in #343 and #190 .
I boiled it down to the fact that this condition was never met because my dataset is very big. I realized in practice max_total_droplets is hardcoded to 70000 (in the get_priors function signature, max_total_droplets has a default of const.MAX_TOTAL_DROPLETS_GUESSED, which is set to 70000 here)

Another user described having issues with a big dataset too, which I would guess is a similar situation to mine.

I'll open a PR shortly to try and address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant