Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tab broken in Tauri #798

Closed
jasonjgardner opened this issue Dec 17, 2022 · 0 comments
Closed

Image tab broken in Tauri #798

jasonjgardner opened this issue Dec 17, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jasonjgardner
Copy link
Contributor

Summary
TypeError is thrown when attempting to open images in native app

To Reproduce
Attempt to open an image file in the native app

Observed behavior
TypeError: t.getParent is not a function (at window.onunhandledrejection)

Expected behavior
Image tab should work like PWA

Platform (please complete the following information):

  • OS: Windows 11 (Tauri)
  • App Version: v2.5.2

Additional context

  • Could be fixed while working on feat: configure window zoom #775
  • We may want to use <canvas> instead of <img> in ImageTab.
    • That would benefit .tga performance over the current OffscreenCanvas usage.
    • It could also lead to some simple image manipulation options: resizing, hue rotation, etc.
@jasonjgardner jasonjgardner added the bug Something isn't working label Dec 17, 2022
solvedDev added a commit that referenced this issue Dec 18, 2022
Joelant05 pushed a commit that referenced this issue Dec 18, 2022
@solvedDev solvedDev self-assigned this Dec 18, 2022
@solvedDev solvedDev added this to the v2.5.3 milestone Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Done
Development

No branches or pull requests

2 participants