Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seems unnecessary replace usage left in go.mod #13

Open
Morty-luo opened this issue Feb 11, 2023 · 2 comments
Open

seems unnecessary replace usage left in go.mod #13

Morty-luo opened this issue Feb 11, 2023 · 2 comments

Comments

@Morty-luo
Copy link

It seems that module github.com/brancz/prometheus-example-app at now directly depends on v1.3.0 of github.com/prometheus/client_golang.

https://github.com/brancz/prometheus-example-app/blob/master/go.mod#L6

github.com/prometheus/client_golang v1.3.0

So, replace usage left in go.mod makes no sense. Should it be dropped?

https://github.com/brancz/prometheus-example-app/blob/master/go.mod#L10

replace github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.3.0
@brancz
Copy link
Owner

brancz commented Feb 11, 2023

Huh I don’t even understand how that got there. Absolutely! Do you want to open a PR to remove it?

@Morty-luo
Copy link
Author

Simply run go mod edit -dropreplace=github.com/prometheus/client_golang should be able to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants