-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] "Check orientation" button in napari not consistent with registration results for hemisphere #200
Comments
Thanks for raising this @pderdeyn, we'll take a look. @alessandrofelder I wonder if this is related to what we saw with napari in 2D/3D on Friday? Is it possible that there's something going on with 2D and 3D visualisation in napari, so that in one of the views, the data is (or at least appears to be) flipped? |
Maybe... we should find a clear way to check this for ourselves (that doesn't require neuroanatomy knowledge) and then discuss it with the napari community if needed? |
I had a quick look at this last week, and it looks like the issue is somewhere in the intersection of setting the hemisphere and creating the projections. |
I think I'm missing something here. In the orientation checking function, the input data (napari layer) is reoriented (using brainglobe-space) to the atlas orientation. This looks correct ( However, when looking at the projection images in the above comment, it seems that the first projection (bottom left) is correct (assuming the view is front to back), but the second (bottom middle) is not (assuming the view is top down). I don't think we can say anything about the third (bottom right). |
@IgorTatarnikov and I spent some time diagnosing this.
|
* add test for check_orientation bug #200 * hide left hemi when right requested, and vice-versa
Fantastic. Thanks for the fix you all <3 |
Hey @pderdeyn, a new version with this fix should be out in an hour or so. |
I just wanted to confirm that I tried this today on an updated version and it works as expected. Thanks again |
Reopening this, as this image.sc issue suggests that there may still be a problem: |
Describe the bug
Orientation doesn't seem to be consistent between the "Check orientation" button in napari brainreg plugin versus when running the registration. The "left-right" lateral direction seems to be flipped between the two for my useage. Note that I am using a single hemisphere
To Reproduce
I have one hemisphere of an imaged brain to align with an atlas. Using the check orientation button in napari's brain reg plugin, I find that my data orientation should be
lpi
for a brain geometry ofLeft hemisphere
(screenshot 1). However, when I run this hemisphere through brain reg, I find that the atlas is actually the incorrect lateral orientation and left and right need to be flipped (screenshot 2). I'm able to fix my brain my switching torpi
(screenshot 4), even though the "check orientation" results don't look correct anymore (screenshot 3).Expected behaviour
Registration should occur with the correct orientation if the "Check orientation" results look good
Screenshots
"Check orientation" results for
lpi
Registration results for
lpi
"Check orientation" results for
rpi
Registration results for
rpi
Computer used (please complete the following information):
The text was updated successfully, but these errors were encountered: