-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
architecture doesn't promote community-wide collaboration? #59
Comments
I think there actually are some really big parts of the ANT/ANT-FS code that could be shared. If I understood this correctly python-ant-downloader and the older Garmin devices uses ANT and ANT-FS for search, pair, auth, but doesn't implement the 'file' parts of ANT-FS. In the Other than keeping the ANT/ANT-FS code in a separate library I really wouldn't mind whatever other collaboration - even merging these projects. |
Sorry for my slow reply. There is quite a bit of common code. Ant as well as paring / session is all identical. The main difference is that once a connection is created with the watch the older devices I support us Garmin's old USB interface spec tunneled over ant, instead of ant-fs. The bad news; during my research writing this software I signed up as an ant-fs adopter. I'm not a lawyer but accepting the adopter agreement makes me uncomfortable contributing to an open-source ant-fs implementation. If you our anyone is interested in forking my implementation with ant-fs support, I can provide help understanding the code. I think you'd quickly look at my code and decide its ugly, and you prefer your own ant implementation. |
Sorry for my late reply. Vaction. I've also signed the adopter agreement so the openant project is already 'tainted' by that so contributing to openant shouldn't really be a problem. |
To keep things simple, I have to assign copyright to any future opensource contributions to my employer. I'm not comfortable doing that in ant-fs domain since I don't know how the adopter agreement taints my work. If I find some time (which could be hard), I'll to try cleaning-up or port some feature-gaps to your project. I think as far a implementing the my old protocol on another stack; its hard for me to justify the time. My software should obsolete itself in a couple years once there are no more 405/410 watches. |
Hi there,
Firstly thanks for your great work on this project!
If I understand correctly from your README and from Tigge/openant#1, in the Linux Garmin syncing world, there seem to be 4 distinct challenges:
.fit
/.tcx
files to Garmin ConnectBearing these in mind, it seems the following observations are true:
antfs-cli
, which by use of a plugin system will address 1., 2., 3., and 4.Forgive me if I misunderstood something, but it seems to me that even though there is a large overlap in goals between this project and @Tigge's work, there is very little opportunity for code sharing, even though all the existing code is Python. I feel that the Linux part of the Garmin community is relatively tiny, and IMHO it would be a shame if this tiny community split into two fragments rather than working together on a universal solution. Is there a way that the two projects could be united so that we can progress much faster? Here are a few architectural suggestions:
antfs-cli
I realise that in the short term this would require a bit more work, but in the longer term I think it could benefit our small community a lot.
Thanks for listening!
(This suggestion was prompted by the discussion in Tigge/antfs-cli#96. See also Tigge/openant#1.)
The text was updated successfully, but these errors were encountered: