Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Poly Fluid Sizing #5

Open
aerni opened this issue Aug 17, 2018 · 4 comments
Open

FR: Poly Fluid Sizing #5

aerni opened this issue Aug 17, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@aerni
Copy link

aerni commented Aug 17, 2018

I love the idea of fluid design for typograhpy, containers etc. However, I've found myself limited by only having one min and max value. I've been playing around with the approach called Poly Fluid Sizing presented in this article. Is this possible to implement?

@aerni
Copy link
Author

aerni commented Mar 18, 2019

@bradlc Do you think you could add this feature? I tried to implement it myself but am failing at my limited JavaScript knowledge. I imagine the configuration to be something like the following, where the key is the screen size. And the key can take in the unit of choice.

padding: {
    sm: {
        '320px': '1rem',
	'640px': '2rem',
	'400px': '4rem',
    },
    md: {
	'20rem': '2rem',
	'40rem': '4rem',
	'87.5rem': '5rem',
    }
}

This is the Poly Fluid Sizing repo: https://github.com/Jakobud/poly-fluid-sizing

@bradlc
Copy link
Owner

bradlc commented Mar 25, 2019

Hey @aerni90. I’ve had a quick look at this and I quite like it. I’ll have a go at implementing it and potentially update the plugin to use this method instead.

@bradlc bradlc added the enhancement New feature or request label Mar 25, 2019
@aerni
Copy link
Author

aerni commented Mar 26, 2019

Awesome! If you need help testing or anything, let me know.

@aerni
Copy link
Author

aerni commented May 16, 2019

@bradlc Are you thinking of completing this implementation any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants