Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes for padding/margin not standard #3

Open
pandroid opened this issue Apr 16, 2018 · 1 comment
Open

Classes for padding/margin not standard #3

pandroid opened this issue Apr 16, 2018 · 1 comment

Comments

@pandroid
Copy link

pandroid commented Apr 16, 2018

Hey @bradlc,
while further working I noticed something else:

The plugin doesn't generate tailwinds standard classes for padding/margin
Tailwind:
.p{side?}-{size}, .m{side?}-{size}

Plugin:
.p-{side?}-{size}, .m-{side?}-{size}

and it doesn't output tailwinds standard classes for vertical / horizontal side
.py-sm-fluid / .px-sm-fluid / .my-sm-fluid / .mx-sm-fluid

Maybe it's obsolet because classes for top, left, right, bottom are there. But its a little confusing because of tailwinds standards.

Maybe it would be a good alternative to make it optional:
Option: classes for horizontal/vertical
Option: classes for top/bottom/right/left

@pandroid pandroid changed the title Classes for padding horizontal / vertical missing Classes for padding/margin not standard Apr 17, 2018
@bradlc
Copy link
Owner

bradlc commented Apr 17, 2018

Nice spot @pandroid! This oversight has happened because some class names do use a hyphen (e.g. rounded-t-sm) and some don’t (e.g. pr-3).

I agree that the plugin should generate vertical and horizontal class names as well.

Thanks again for posting these issues. I have only used the plugin for text sizing so far so these issues have gone unnoticed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants