Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feelin a peer dependency #23

Open
Skaiir opened this issue Oct 18, 2023 · 1 comment
Open

Make feelin a peer dependency #23

Skaiir opened this issue Oct 18, 2023 · 1 comment
Assignees
Labels

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Oct 18, 2023

What should we do?

Ideally we should not have a hard dependency on feelin. Switching over to peer dependency should be the right thing to do here

Why should we do it?

There are multi angles here, but first and foremost, feelers is a templating structure built around feelin, not a direct consumer of it. It in theory should work for any somewhat similarly structured expression language. It certainly should always work with newer versions of feelin. We mainly rely on feelin for the syntax highlighting which again, is feelin's business not this library's. Furthermore, the scenarios in which we (and presumably others) use this library often have us depending on feelin as well directly.

So, in the interest of simplicity, I think we should just move this to a peer dependency, check this doesn't cause any issues in integrations and just stop having to worry about version matches and such.

@Skaiir Skaiir self-assigned this Oct 18, 2023
@nikku
Copy link
Member

nikku commented Oct 18, 2023

@Skaiir Another angle to consider here:

Can we ensure that feelin is going to be used anyway, wherever feelers is used? If that is the case, it is fine to be a peer dependency (or no dependency at all).

If that is not the case then we can resort to de-duplication being done by bundlers. They do a great job at that, nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants