Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow labels on sequence flows that are not outgoing from OR/XOR gateways #123

Open
till-stadtler opened this issue Dec 11, 2023 · 3 comments · May be fixed by #129
Open

Disallow labels on sequence flows that are not outgoing from OR/XOR gateways #123

till-stadtler opened this issue Dec 11, 2023 · 3 comments · May be fixed by #129
Labels
backlog Queued in backlog rules Concerning existing or missing rules

Comments

@till-stadtler
Copy link

The rule should detect the following modeling patterns

Sequence flows that are not outgoing from OR/XOR gateways should not have labels. Labeling these sequence flows can lead to confusion.
no-labels-on-standard-sequence-flows-1

Instead either use no label, because the following activity speaks for itself, or an intermediate none event:
no-labels-on-standard-sequence-flows-2

How does the rule improve the BPMN diagram?

Instead of having confusing labels on sequence flows that are not outgoing from OR/XOR gateways, they are either removed or replaced with an intermediate none event.

In Camunda, intermediate none events can be used for business intelligence in Optimize.

Rule Details

  • Name: no-isolated-sequence-flow-label
  • Default notification level: warn

What alternatives did you consider?

BPMN models continue to contain labels on sequence flows that are not outgoing from OR/XOR gateways.

@till-stadtler till-stadtler added the rules Concerning existing or missing rules label Dec 11, 2023
@nikku
Copy link
Member

nikku commented Dec 11, 2023

I assume this does not apply to conditional labels, right?

image

@till-stadtler
Copy link
Author

You are right! Labels should also be allowed on conditional sequence flows!

@nikku nikku added the backlog Queued in backlog label Dec 12, 2023 — with bpmn-io-tasks
@nikku nikku self-assigned this Jan 26, 2024
@nikku nikku linked a pull request Jan 30, 2024 that will close this issue
@nikku
Copy link
Member

nikku commented Jan 30, 2024

Will be addressed via #129 (some more work needed to wrap that one up, some day maybe).

@nikku nikku removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog rules Concerning existing or missing rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants