-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a linkchecker for the front end #963
Comments
We can implement this using a GitHub action, I like to work on this issue |
@JeelRajodiya, yeah, that's a great idea. Also, we need to add Vercel to our repository so that anyone making changes can submit a pull request. This way, we can check their pull request's UI with Vercel's development environment before merging it into the main branch. |
I would hope there's some more "integrated" way to run lychee over the output of vite and/or React applications, so that it's simply a final step in the build process. If you or anyone thinks they're able to can you investigate doing things that way? |
Sure! I'll investigate on that |
I found a npm package puppeteer that can crawl a SPA (Single-Page Application) and generate pre-rendered content (i.e. "SSR" (Server-Side Rendering)). I am thinking of this flow: First build the project -> run puppeteer to generate a static html file -> run lychee on the generated static html file |
@Julian let me know if I should proceed or not |
Thanks for the research -- I'm not fully thrilled with that kind of setup, but I don't yet have any other suggestion. Let's hold off for a bit then and I'll have to have a look at trying to find something that illustrates, or else I'll give up and we can go with something like that, but I want to look first. |
We should link check every link contained in the frontend UI with an automated link checker in order to catch broken links.
The text was updated successfully, but these errors were encountered: