Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doEditContent is deprecated #60

Open
bovender opened this issue Mar 12, 2022 · 4 comments
Open

doEditContent is deprecated #60

bovender opened this issue Mar 12, 2022 · 4 comments

Comments

@bovender
Copy link
Owner

Need to find a different implementation.

LinkTitles/includes/Extension.php

Line 110 in 749211f

$source->getPage()->doEditContent(

@bertrandgorge
Copy link
Contributor

Hello @bovender, would it be the reason why changes by LinkTitles are not marked as minor...?

Apparently we should use PageUpdater::saveRevision instead : https://doc.wikimedia.org/mediawiki-core/REL1_33/php/classWikiPage.html#a82bc37fb113bfbbf5d49f2736de1a668

@bovender
Copy link
Owner Author

Thanks, I'll look into it (also happy to consider pull requests ;-) ).

@bertrandgorge
Copy link
Contributor

Here you go. I confirm that the changes are now properly marked as minor. Added benefit, the link no shows properly!

image

@bovender
Copy link
Owner Author

Awesome, thanks a million!

bovender added a commit that referenced this issue Jul 27, 2022
@bovender
Merge pull request #64 from neayi/fix-60-doeditcontent-is-deprecated
289034e 
Fixed issue #60: replaced deprecated method doEditContent with PageUpdater::saveRevision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bovender @bertrandgorge