Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add colour themes #58

Open
Perifractic opened this issue Apr 23, 2019 · 5 comments
Open

Please add colour themes #58

Perifractic opened this issue Apr 23, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@Perifractic
Copy link

Inbox is great, but the interface was starting to look old. If you could add some colour theming options in time, it'd make this better than Inbox! Thanks for the great work.

@russelldc
Copy link
Collaborator

Somewhat related:
if I remember right, @RedcoatAsher was planning on adding some form of Dark Mode theme.

@Perifractic
Copy link
Author

Perifractic commented Apr 23, 2019 via email

@russelldc russelldc added the enhancement New feature or request label Apr 29, 2019
@russelldc
Copy link
Collaborator

We should also allow backgrounds, like Gmail. Those are selectable in the same section as color themes, in the settings gear icon at the top right -> Themes.

If you have a background image set now, it applies almost the same changes that break Gmail's built-in Dark theme. While the text of the email content doesn't turn white like Dark mode, some of the UI, like the left menu items get an ugly text shadow, and a majority of the toolbar on top of opened emails and the email list turn white.

To allow these to work out, we'd need to remove the gray background color from a lot of the elements, setting them to transparent instead.

@russelldc
Copy link
Collaborator

I've got a branch going here, very WIP:
https://github.com/boukestam/inbox-in-gmail/tree/themes

A few problems to resolve:

  1. Gmail's default theme is white background, but I assume we'd want to default to Inbox-like gray
  2. Enforce black/dark text color on email list items (Icons, Subject, Author, Excerpt)
  3. Stop enforcing gray text on left menu, so Gmail can set that text to white when appropriate (Dark themes, backgrounds)
  4. Top bar should maybe be translucent or transparent, like Gmail, so the chosen color/background shows through

@russelldc
Copy link
Collaborator

russelldc commented Apr 30, 2019

One thing that makes this a bit difficult is that it seems like Gmail doesn't apply a certain class on theme-change, it just loads in a new css stylesheet entirely. So it's not obvious how to decide when the text and icons should be light or dark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants