Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimodal support by making nodes generic over their value #441

Open
timonv opened this issue Nov 8, 2024 · 0 comments
Open

Multimodal support by making nodes generic over their value #441

timonv opened this issue Nov 8, 2024 · 0 comments
Labels
breaking change enhancement New feature or request

Comments

@timonv
Copy link
Member

timonv commented Nov 8, 2024

Is your feature request related to a problem? Please describe.
Indexing pipelines currently only support textual data. There are more kinds of data, images, byte slices, various forms of structured data, binary, etcetera.

Describe the solution you'd like
Proposal is to make nodes generic over the inner value, i.e. a Node<Text>, Node, Node, Node` (or their underlying primitives). Added benefit that transformers can restrict the kind of data they can work with.

Additionally, for an initial release:

  • Pipeline must be able to change the node type after any step to a new type
  • All current steps have to be updated, extra care for existing steps that they work with all / the ones they support
  • Debug has to be implemented correctly, nobody wants binary data in their logs by accident

Describe alternatives you've considered
One alternative is an enum. However, that means handling the enum in every transformation step and limits the typesafety.

Additional context
See #356 for a cool idea that could use this

@timonv timonv added enhancement New feature or request breaking change labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant