Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thiserror; improved error handling #152

Open
timonv opened this issue Jul 12, 2024 · 0 comments
Open

thiserror; improved error handling #152

timonv opened this issue Jul 12, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@timonv
Copy link
Member

timonv commented Jul 12, 2024

Throughout the library we currently use anyhow. At several points in the indexing step, it makes (a lot) of sense to have domain specific errors so library users can handle them how they see fit.

Non exclusive, some boundaries I'm thinking off:

  • Internal result of the indexing and query pipelines (Result and Result respectively>)
  • Most concrete transformations
  • Inference calls (SimplePrompt)
  • Embedding calls (EmbeddingModel and SparseEmbeddingModel)

For example, if an inference calls fails due to a rate limit, a node could be retried.

@timonv timonv added enhancement New feature or request good first issue Good for newcomers labels Jul 12, 2024 — with Connector GitHub for Miro
@timonv timonv added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant