user variable ignored in "Download destination directory:"

[eleaner]

Describe the bug
"Download destination directory:" reverts to /home/user/iCloud
despite of user set in environment

Expected behaviour
/home/${user}/iCloud

Actual behaviour
/home/user/iCloud

System (The following information must be entered or the issue will be closed):

• OS: Debian
• Version
  -12

Debug log file

2024-10-29 21:25:42 INFO     ***** boredazfcuk/icloudpd container v1.0.989_28-10-2024 started *****
2024-10-29 21:25:42 INFO     ***** For support, please go here: https://github.com/boredazfcuk/docker-icloudpd *****
2024-10-29 21:25:42 INFO     Alpine Linux 3.20.3
2024-10-29 21:25:42 INFO     Python version: 3.12.7
2024-10-29 21:25:43 INFO     icloud-photos-downloader version: 1.24.1
2024-10-29 21:25:43 INFO     Checking for updates...
2024-10-29 21:25:43 INFO      - Current version is up to date
2024-10-29 21:25:43 INFO     Loading configuration from: /config/icloudpd.conf
2024-10-29 21:25:43 DEBUG    Running user id: 0
2024-10-29 21:25:43 DEBUG    Running group id: 0
2024-10-29 21:25:43 DEBUG    Local user: xxx:1000
2024-10-29 21:25:43 DEBUG    Local group: xxx:1000
2024-10-29 21:25:43 DEBUG    Force GID: false
2024-10-29 21:25:43 DEBUG    LAN IP Address: 172.19.0.3
2024-10-29 21:25:43 DEBUG    Default gateway: 172.19.0.1
2024-10-29 21:25:43 DEBUG    DNS server: 127.0.0.11
2024-10-29 21:25:43 DEBUG    IP address for icloud.com: 17.253.144.10
2024-10-29 21:25:43 DEBUG    Route check to icloud.com successful
2024-10-29 21:25:43 INFO     Debug logging: Enabled
2024-10-29 21:25:43 INFO     Apple ID: (hidden)
2024-10-29 21:25:43 INFO     Cookie path: /config/(hidden)
2024-10-29 21:25:43 INFO     Cookie expiry notification period: 14
2024-10-29 21:25:43 INFO     Download destination directory: /home/user/iCloud
2024-10-29 21:25:43 INFO     Download directory does not exist```

[eleaner]

I am not sure if it is an actual error anymore
it looks like it is read from icloudpd.conf
and possibly this is the intended design?

[boredazfcuk]

If you set the "download_path" environment variable, it will configure the setting in the icloudpd.conf file accordingly.

If you do not set the download path, it will configure it to /home/${user}/iCloud.

If user is not set at this point, it will default to user so /home/user/iCloud.

I have download_path=/home/boredazfcuk/iCloud in my icloudpd.conf file and that's where it downloads to.

I only create containers with a single environment variable TZ=Europe/London. Nothing else is required as they are all loaded from icloudpd.conf.