Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC suggest-override warnings #104

Open
EugeneZelenko opened this issue Apr 13, 2020 · 1 comment
Open

GCC suggest-override warnings #104

EugeneZelenko opened this issue Apr 13, 2020 · 1 comment

Comments

@EugeneZelenko
Copy link
Contributor

EugeneZelenko commented Apr 13, 2020

Complete list of warnings when Boost 1.72 is built with GCC 7.5 with -Wsuggest-override added to cxxflags. Duplicated warnings from same location are omitted:

./boost/regex/v4/cpp_regex_traits.hpp:102:1: warning: ‘std::basic_streambuf<_CharT, _Traits>* boost::re_detail_107200::parser_buf::setbuf(boost::re_detail_107200::parser_buf::char_type*, boost::re_detail_107200::parser_buf::streamsize) [with charT = char; traits = std::char_traits; boost::re_detail_107200::parser_buf::char_type = char; boost::re_detail_107200::parser_buf::streamsize = long int]’ can be marked override [-Wsuggest-override]
./boost/regex/v4/cpp_regex_traits.hpp:110:1: warning: ‘boost::re_detail_107200::parser_buf::pos_type boost::re_detail_107200::parser_buf::seekoff(boost::re_detail_107200::parser_buf::off_type, std::ios_base::seekdir, std::ios_base::openmode) [with charT = char; traits = std::char_traits; boost::re_detail_107200::parser_buf::pos_type = std::fpos<__mbstate_t>; boost::re_detail_107200::parser_buf::off_type = long int; std::ios_base::seekdir = std::_Ios_Seekdir; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Wsuggest-override]
./boost/regex/v4/cpp_regex_traits.hpp:156:1: warning: ‘boost::re_detail_107200::parser_buf::pos_type boost::re_detail_107200::parser_buf::seekpos(boost::re_detail_107200::parser_buf::pos_type, std::ios_base::openmode) [with charT = char; traits = std::char_traits; boost::re_detail_107200::parser_buf::pos_type = std::fpos<__mbstate_t>; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Wsuggest-override]

BOOST_OVERRIDE was introduced in boostorg/config@ffe4e0f.

@EugeneZelenko
Copy link
Contributor Author

See fixes in #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant