Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IterableWeakSet IterableWeakMap classes #9

Open
bogeeee opened this issue Jul 28, 2024 · 0 comments
Open

Implement IterableWeakSet IterableWeakMap classes #9

bogeeee opened this issue Jul 28, 2024 · 0 comments

Comments

@bogeeee
Copy link
Owner

bogeeee commented Jul 28, 2024

Needed to properly clean up callbacks on connection but not cause a memory leak by all the on-socketconnection-close handlers itsself: The ClientCallbacks / ClientCallbacksForEntites should be allowed to be forgotten. Also ClientCallbacksForEntities's keys

These classes can be like the ones in the not-so-weak package, but these have the flaws that they

  • don't work, becaues they call registry.register with WeakRef objects as values and unregisterTokens. But both work only with normal objects and fail silently otherwise (=don't fire) - have tested this !
  • Their type parameters are faulty and also their iterator's types don't match those of the base class - maintainer not willing to fix that.

So that cries for a reimplementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant