Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement objects - PointsPrimitive, CurvesPrimitive #6

Open
boberfly opened this issue Feb 3, 2019 · 3 comments
Open

Implement objects - PointsPrimitive, CurvesPrimitive #6

boberfly opened this issue Feb 3, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@boberfly
Copy link
Owner

boberfly commented Feb 3, 2019

Currently there is conversion code to convert IECore::CurvesPrimitive to Cycles, but this is not tested yet and it isn't too clear if they need to be attached to a ccl::ParticleSystem (via IECore::PointsPrimitive) which also hasn't been implemented yet.

@boberfly boberfly added the enhancement New feature or request label Feb 3, 2019
@boberfly boberfly added this to the 1.0 milestone Feb 3, 2019
@boberfly boberfly self-assigned this Feb 3, 2019
@boberfly
Copy link
Owner Author

boberfly commented Oct 9, 2019

PointsPrimitive are now implemented:
https://github.com/boberfly/GafferCycles/blob/master/include/GafferCycles/IECoreCyclesPreview/ParticleAlgo.h
However Cycles doesn't have a way to render these, but under the hood this is used to apply per-particle info onto instanced geometry from Gaffer's Instancer if you make sure to transfer particular named primvars to attributes (this will be available from the particle_info shader):
"index" or Gaffer's "instanceIndex"
"age"
"lifetime"
"location" or Gaffer's "P"
"rotation" or Gaffer's "orientation"
"size" or Gaffer's "width"

I will re-visit this if this patch ever goes mainline and I can render them as spheres:
https://developer.blender.org/D3818

@boberfly
Copy link
Owner Author

@murraystevenson kindly tested a scene with curves and supplied a PR fix here:
#23

So CurvesPrimitive should convert now, but it has been reported that the curve settings in CyclesOptions aren't being set right yet.

@boberfly
Copy link
Owner Author

boberfly commented Jan 8, 2020

CyclesOptions are working, true PointsPrimitive with https://developer.blender.org/D3818 I am moving to post-1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant