Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee could be underestimated if input address type != output address type #389

Open
sander2 opened this issue Oct 16, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@sander2
Copy link
Contributor

sander2 commented Oct 16, 2024

Right now, the code assumes that the output address is of the same type as the input address. Since the fee estimation is used to determine the maximum amount we can send, we need to be as pessimistic as possible. Meaning, we should assume by default that the output address is of the type that is most expensive to send funds to. And it'd be good if this type could be overwritten by the function parameters.

@sander2 sander2 added the enhancement New feature or request label Oct 16, 2024
@tomjeatt tomjeatt self-assigned this Oct 30, 2024
@sander2 sander2 changed the title Fee could be underestimated Fee could be underestimated if input address type != output address type Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: New 🆕
Development

No branches or pull requests

2 participants