diff --git a/src/app/common/table/columns/ago-date/ago-date-column.component.html b/src/app/common/table/columns/ago-date/ago-date-column.component.html index 92883f4b..f362eb7e 100644 --- a/src/app/common/table/columns/ago-date/ago-date-column.component.html +++ b/src/app/common/table/columns/ago-date/ago-date-column.component.html @@ -1,14 +1,17 @@ - - + + {{ header() ?? (name | titlecase) }} - - + + @if (headerTemplate(); as tpl) { + + } +
diff --git a/src/app/common/table/columns/ago-date/ago-date-column.component.ts b/src/app/common/table/columns/ago-date/ago-date-column.component.ts index 712aac45..e13fc2a0 100644 --- a/src/app/common/table/columns/ago-date/ago-date-column.component.ts +++ b/src/app/common/table/columns/ago-date/ago-date-column.component.ts @@ -5,7 +5,7 @@ import { Component, booleanAttribute, input } from '@angular/core'; import { NgbTooltip } from '@ng-bootstrap/ng-bootstrap'; import { AgoDatePipe, UtcDatePipe } from '../../../pipes'; -import { AsySortHeaderComponent } from '../../sort/asy-sort-header/asy-sort-header.component'; +import { AsyHeaderSortComponent } from '../../sort/asy-header-sort/asy-header-sort.component'; import { DateColumnComponent } from '../date/date-column.component'; @Component({ @@ -15,7 +15,7 @@ import { DateColumnComponent } from '../date/date-column.component'; CommonModule, CdkTableModule, UtcDatePipe, - AsySortHeaderComponent, + AsyHeaderSortComponent, AgoDatePipe, NgbTooltip ], diff --git a/src/app/common/table/columns/asy-abstract-value-column.component.ts b/src/app/common/table/columns/asy-abstract-value-column.component.ts index 6ea0d4fa..a32f4fe0 100644 --- a/src/app/common/table/columns/asy-abstract-value-column.component.ts +++ b/src/app/common/table/columns/asy-abstract-value-column.component.ts @@ -6,7 +6,7 @@ import { HeaderTemplateDirective } from './header-template.directive'; @Directive({ standalone: true }) export abstract class AsyAbstractValueColumnComponent extends AsyAbstractColumnComponent { readonly header = input(); - readonly sortable = input(true, { transform: booleanAttribute }); + readonly sortable = input(false, { transform: booleanAttribute }); readonly headerTemplate = contentChild(HeaderTemplateDirective, { read: TemplateRef }); } diff --git a/src/app/common/table/columns/date/date-column.component.html b/src/app/common/table/columns/date/date-column.component.html index bf918206..af78c7e1 100644 --- a/src/app/common/table/columns/date/date-column.component.html +++ b/src/app/common/table/columns/date/date-column.component.html @@ -1,14 +1,17 @@ - - + + {{ header() ?? (name | titlecase) }} - - + + @if (headerTemplate(); as tpl) { + + } + {{ obj[name] | utcDate: format() }} diff --git a/src/app/common/table/columns/date/date-column.component.ts b/src/app/common/table/columns/date/date-column.component.ts index f881a5ff..d72147c7 100644 --- a/src/app/common/table/columns/date/date-column.component.ts +++ b/src/app/common/table/columns/date/date-column.component.ts @@ -2,14 +2,14 @@ import { CdkTableModule } from '@angular/cdk/table'; import { CommonModule } from '@angular/common'; import { Component, input } from '@angular/core'; -import { UtcDatePipe } from '../../../pipes/utc-date-pipe/utc-date.pipe'; -import { AsySortHeaderComponent } from '../../sort/asy-sort-header/asy-sort-header.component'; +import { UtcDatePipe } from '../../../pipes'; +import { AsyHeaderSortComponent } from '../../sort/asy-header-sort/asy-header-sort.component'; import { AsyAbstractValueColumnComponent } from '../asy-abstract-value-column.component'; @Component({ selector: 'asy-date-column', standalone: true, - imports: [CommonModule, CdkTableModule, UtcDatePipe, AsySortHeaderComponent], + imports: [CommonModule, CdkTableModule, UtcDatePipe, AsyHeaderSortComponent], templateUrl: './date-column.component.html', styleUrls: ['./date-column.component.scss'] }) diff --git a/src/app/common/table/columns/expandable-list/asy-expandable-list-column.component.html b/src/app/common/table/columns/expandable-list/asy-expandable-list-column.component.html index 6b752ea6..be06952d 100644 --- a/src/app/common/table/columns/expandable-list/asy-expandable-list-column.component.html +++ b/src/app/common/table/columns/expandable-list/asy-expandable-list-column.component.html @@ -1,14 +1,17 @@ - +
{{ header() ?? (name | titlecase) }} - - +
+ @if (headerTemplate(); as tpl) { + + } + - - + + {{ header() ?? (name | titlecase) }} - - + + @if (headerTemplate(); as tpl) { + + } + {{ obj[name] || defaultValue() }} diff --git a/src/app/common/table/columns/text/text-column.component.ts b/src/app/common/table/columns/text/text-column.component.ts index f39fd3da..3d9bfb9c 100644 --- a/src/app/common/table/columns/text/text-column.component.ts +++ b/src/app/common/table/columns/text/text-column.component.ts @@ -2,13 +2,13 @@ import { CdkTableModule } from '@angular/cdk/table'; import { CommonModule } from '@angular/common'; import { Component, input } from '@angular/core'; -import { AsySortHeaderComponent } from '../../sort/asy-sort-header/asy-sort-header.component'; +import { AsyHeaderSortComponent } from '../../sort/asy-header-sort/asy-header-sort.component'; import { AsyAbstractValueColumnComponent } from '../asy-abstract-value-column.component'; @Component({ selector: 'asy-text-column', standalone: true, - imports: [CommonModule, AsySortHeaderComponent, CdkTableModule], + imports: [CommonModule, AsyHeaderSortComponent, CdkTableModule], templateUrl: './text-column.component.html', styleUrls: ['./text-column.component.scss'] }) diff --git a/src/app/common/table/filter/_shared.scss b/src/app/common/table/filter/_shared.scss index 7ec4f4df..0c03445e 100644 --- a/src/app/common/table/filter/_shared.scss +++ b/src/app/common/table/filter/_shared.scss @@ -5,6 +5,8 @@ $filter-dropdown-font-size: 0.75rem !default; $filter-dropdown-max-height: 250px !default; button.dropdown-toggle { + position: relative; + top: -2px; background: inherit; border: none; font: inherit; diff --git a/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.html b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.html new file mode 100644 index 00000000..056c73d3 --- /dev/null +++ b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.html @@ -0,0 +1,16 @@ + diff --git a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.scss b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.scss similarity index 68% rename from src/app/common/table/sort/asy-sort-header/asy-sort-header.component.scss rename to src/app/common/table/sort/asy-header-sort/asy-header-sort.component.scss index 0bee544c..ee73f486 100644 --- a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.scss +++ b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.scss @@ -1,11 +1,12 @@ @import '../../../../../styles/shared'; +:host { + display: inline-block; +} + button { background: inherit; - border: none; font: inherit; - padding-top: 0; - padding-bottom: 0; } .fa-solid { @@ -23,8 +24,3 @@ button { line-height: 2px; width: 22px; } - -.asy-sort-header-sortable { - cursor: pointer; - padding-right: 5px; -} diff --git a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.ts b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.ts similarity index 91% rename from src/app/common/table/sort/asy-sort-header/asy-sort-header.component.ts rename to src/app/common/table/sort/asy-header-sort/asy-header-sort.component.ts index 3891f759..88ff1bcd 100644 --- a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.ts +++ b/src/app/common/table/sort/asy-header-sort/asy-header-sort.component.ts @@ -24,21 +24,20 @@ interface AsySortHeaderColumnDef { } @Component({ - selector: '[asy-sort-header]', - templateUrl: './asy-sort-header.component.html', - styleUrls: ['./asy-sort-header.component.scss'], + selector: 'asy-header-sort', + templateUrl: './asy-header-sort.component.html', + styleUrls: ['./asy-header-sort.component.scss'], // eslint-disable-next-line @angular-eslint/no-host-metadata-property host: { - class: 'asy-sort-header', + class: 'text-nowrap', '(click)': '_handleClick()', - '[class.asy-sort-header-sorted]': 'isSorted()', '[attr.aria-sort]': '_getAriaSortAttribute()' }, changeDetection: ChangeDetectionStrategy.OnPush, standalone: true, imports: [] }) -export class AsySortHeaderComponent implements AsySortable, OnDestroy, OnInit { +export class AsyHeaderSortComponent implements AsySortable, OnDestroy, OnInit { readonly #destroyRef = inject(DestroyRef); readonly #changeDetectorRef = inject(ChangeDetectorRef); @@ -51,7 +50,8 @@ export class AsySortHeaderComponent implements AsySortable, OnDestroy, OnInit { * ID of this sort header. If used within the context of a CdkColumnDef, this will default to * the column's name. */ - @Input('asy-sort-header') + // eslint-disable-next-line @angular-eslint/no-input-rename + @Input('sortId') id: string; /** Overrides the sort start value of the containing AsySort for this AsySortable. */ diff --git a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.html b/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.html deleted file mode 100644 index 456ee5c5..00000000 --- a/src/app/common/table/sort/asy-sort-header/asy-sort-header.component.html +++ /dev/null @@ -1,18 +0,0 @@ -
- -
diff --git a/src/app/common/table/sort/public-api.ts b/src/app/common/table/sort/public-api.ts index bb85604d..eadf5b81 100644 --- a/src/app/common/table/sort/public-api.ts +++ b/src/app/common/table/sort/public-api.ts @@ -1,2 +1,2 @@ -export * from './asy-sort-header/asy-sort-header.component'; +export * from './asy-header-sort/asy-header-sort.component'; export * from './asy-sort.directive'; diff --git a/src/app/core/admin/cache-entries/list-cache-entries/list-cache-entries.component.html b/src/app/core/admin/cache-entries/list-cache-entries/list-cache-entries.component.html index 4f20ca86..8b466e81 100644 --- a/src/app/core/admin/cache-entries/list-cache-entries/list-cache-entries.component.html +++ b/src/app/core/admin/cache-entries/list-cache-entries/list-cache-entries.component.html @@ -21,14 +21,14 @@

Cache Entries

- + - + EUAs cdk-table [dataSource]="dataSource" > - + - + - + - - - + + + System Feedback {{ feedback.creator.organization }} - - + + - + @@ -88,12 +90,12 @@

System Feedback

{{ feedback.body }} - - - + + + - - +
Value {{ entry.value | json }} Title + Title + {{ eua.title }} @@ -53,14 +55,16 @@

EUAs

Text + Text + {{ eua.text }} Type + Type + {{ feedback.type | titlecase }} - Status + + Status @@ -148,7 +150,9 @@

System Feedback

Assignee + Assignee +