Use the privacy of the external source to set defaults #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektash
reviewed
Jan 25, 2018
| @@ -342,7 +349,8 @@ def partially_dependent_visualizations | |||
| private | |||
|
|
|||
| def default_privacy_value | |||
| user.try(:private_tables_enabled) ? PRIVACY_PRIVATE : PRIVACY_PUBLIC | |||
| esv = external_source_visualization | |||
| esv.nil? ? (user.try(:private_tables_enabled) ? PRIVACY_PRIVATE : PRIVACY_PUBLIC) : PRIVACY_TEXTS_TO_VALUES[esv.privacy] | |||
mbektash
approved these changes
Jan 25, 2018
vishalya
pushed a commit
that referenced
this pull request
Feb 9, 2018
…geojson-regression-tests Changes geojson_spec to use the configured ogr2ogr binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the external datasource's privacy during the default settings, else it get's set to private and later on all the visualizations are marked as privace, due the the logic in the table_blender.rb