Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mqbs_datastore.t.cpp unit tests #388

Open
1 task done
678098 opened this issue Aug 2, 2024 · 0 comments
Open
1 task done

Improve mqbs_datastore.t.cpp unit tests #388

678098 opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@678098
Copy link
Collaborator

678098 commented Aug 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The current implementation is mostly a copy-paste of bmqt::MessageGUID unit tests.
It has several flaws:

  1. These comments are misleading and not true:

    // Above value is just chosen after looking at the number of collisions
    // by running this test case manually. In most runs, number of
    // collisions was in the range of [0, 3].

  2. The way how mqbs::DataStoreRecordKeys are generated is not representative to the usage pattern in the broker:

    mqbs::DataStoreRecordKey key(i, 7);

To get it right, both args should be modified.

Expected Behavior

No response

Steps To Reproduce

BlazingMQ Version

all

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant