Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temporary folders for ITs with native broker #37

Open
1 task done
678098 opened this issue Sep 22, 2023 · 0 comments
Open
1 task done

Use temporary folders for ITs with native broker #37

678098 opened this issue Sep 22, 2023 · 0 comments
Labels
A-Testing Area: Testing bug Something isn't working

Comments

@678098
Copy link
Collaborator

678098 commented Sep 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

For native broker currently we have some ENV vars being set in the code, but these variables do not do anything right now, because we use static config. Here:

Map<String, String> env = pb.environment();
env.put("BMQ_PREFIX", envPath);
env.put("BMQ_STORAGE", storagePath.toString());
logger.info("BlazingMQ Broker storage directory: {}", storagePath);
outputFile = new File(tmpFolder.resolve("output").toString());
// Common environment vars
env.put("BMQ_PORT", String.valueOf(sessionOptions.brokerUri().getPort()));
env.put("BMQ_HOSTTAGS_FILE", "/bb/bin/bbcpu.lst");
env.put("PYTHONPATH", envPath + "/python");

This means that currently we can use params listed in static config only, so storage path, logs path, broker port are the same for each launched broker. The last means that native IT brokers could only be launched on a default 30114 port, and no parallel ITs execution possible.

We create a TMP folder which should contain storage, logs etc, but we are not able to use it with a static config:

Expected Behavior

Native brokers in ITs should be able to use TMP folders and non-default parameters.

Steps To Reproduce

Launch ITs with -Dit.brokerDir=/path/to/native/broker

BlazingMQ Java SDK Version

0.0.10

Anything else?

No response

@678098 678098 added bug Something isn't working A-Testing Area: Testing labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Testing Area: Testing bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant