Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance wallet integration #24

Open
pikonha opened this issue Dec 17, 2024 · 0 comments
Open

Enhance wallet integration #24

pikonha opened this issue Dec 17, 2024 · 0 comments
Assignees
@eduramme
Labels
enhancement New feature or request

Comments

@pikonha
Copy link
Collaborator

pikonha commented Dec 17, 2024 •
edited by eduramme
Loading

Feature Request

When no wallet is connected the app is unable to fetch any domain from the ponder API or from the ENS subgraph. In fact, it is even unable to go to the /lend page.

Preferred solution

  • Use mainnet as the default network allowing domains to be fetched, but only renting when a wallet is connected.
  • Enable walletConnect and rainbow wallet connections

example: https://github.com/gskril/ens-governor-app
@pikonha pikonha added the enhancement New feature or request label Dec 17, 2024
@pikonha pikonha added this to ENS Dec 17, 2024
@pikonha pikonha moved this to 🔖 TODO in ENS Dec 17, 2024
@pikonha pikonha changed the title Set mainnet as default network Set mainnet as default network when wallet is not connected Dec 17, 2024
@pikonha pikonha changed the title Set mainnet as default network when wallet is not connected Enhance wallet integration Dec 17, 2024
@eduramme eduramme moved this from 🔖 TODO to 🛠️ In Progress in ENS Dec 18, 2024
@eduramme eduramme self-assigned this Dec 18, 2024
@eduramme eduramme moved this from 🛠️ In Progress to 🕵️‍♀️ In Review in ENS Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eduramme eduramme

Labels
enhancement New feature or request
Projects
ENS
Status: 🕵️‍♀️ In Review
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/24-enhance-wallet-integration blockful-io/ens-rental-dapp
2 participants
@pikonha @eduramme