Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool txs in GET_TRANSACTION and GET_ACCOUNT_INFO #255

Open
slowbackspace opened this issue Nov 8, 2024 · 1 comment
Open

Mempool txs in GET_TRANSACTION and GET_ACCOUNT_INFO #255

slowbackspace opened this issue Nov 8, 2024 · 1 comment
Labels
BLOCKED Blocked by another issue enhancement New feature or request

Comments

@slowbackspace
Copy link
Contributor

slowbackspace commented Nov 8, 2024

Blockfrost has API for retrieving txs that are not yet on chain, but are stored in mempool https://docs.blockfrost.io/#tag/cardano--mempool
Let's include these transactions into:

  • GET_ACCOUNT_INFO (for details="txs" and details="txids")
    • To keep backwards compatibility let's introduce it behind new optional parameter includeMempoolTxs: boolean
    • the txs themselves (variant with details="txs" ) should contain an additional field, mempool: boolean, to indicate whether the transaction is in the mempool
  • GET_TRANSACTION
    • same parameter includeMempoolTxs: boolean as above
    • add info into the tx payload (mempool: boolean) so the client can easily distinct if the tx is in mempool or not, without needing to compare the results with the variant without includeMempoolTxs param

In both cases the base format of the mempool tx must be the same as the format for on-chain tx. Mempool tx object may contain additional props.

@slowbackspace slowbackspace added enhancement New feature or request BLOCKED Blocked by another issue labels Nov 8, 2024
@slowbackspace
Copy link
Contributor Author

Ohh putting this feature request on hold as this is actually not something that is doable today as RYO still lack support for the mempool endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Blocked by another issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant