Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: Unnecessary linebreaks for long passwords #4166

Closed
2 tasks done
Jan-Koll opened this issue Oct 25, 2024 · 11 comments
Closed
2 tasks done

Generator: Unnecessary linebreaks for long passwords #4166

Jan-Koll opened this issue Oct 25, 2024 · 11 comments
Labels

Comments

@Jan-Koll
Copy link

Bitwarden Beta

  • I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in bitwarden/mobile

Steps To Reproduce

  1. Go to 'Generator'
  2. Increase password length via the slider

Expected Result

The generated password fills the available horizontal space.

Actual Result

Unnecessary linebreaks are added almost every other line. This results in a lot of vertical space that is required.

Screenshots or Videos

Screenshot_2024-10-25-19-02-32-79_edf9c6c5202cf0aae90965d36a8e7fc4

Additional Context

No response

Build Version

2024.9.0 (19209)

Environment Details

Android 12, default system font size

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@Jan-Koll Jan-Koll added the bug label Oct 25, 2024
@bitwarden-bot
Copy link

Thank you for your report! We've added this to our internal board for review.
ID: PM-14044

@jtodddd
Copy link

jtodddd commented Oct 28, 2024

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@differsthecat
Copy link
Member

This was fixed by this PR, closing 🙂

@vinnyperella
Copy link

vinnyperella commented Nov 1, 2024

This was fixed by this PR, closing 🙂

This is still an issue in 2024.10.2 what version will the fix be implemented in?

Screenshot_20241101-024000.png

@Jan-Koll
Copy link
Author

Jan-Koll commented Nov 4, 2024

I agree, the issue is still there in the latest beta (Version: 2024.10.2 (19397)). Since the changes were merged 3 days ago, my guess is that the next release will include the fix.

@frabera
Copy link

frabera commented Nov 6, 2024

It is still present for me on 2024.11.2

@frabera
Copy link

frabera commented Nov 11, 2024

Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187.

@Jan-Koll
Copy link
Author

@differsthecat @jtodddd Maybe this issue could be opened again, since the problem doesn't seem to be resolved.

Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187.

Interesting. I am on 11.3 currently and I always get 3 characters every other line.

By the way, I just noticed this is also the case for the passphrase generation (so not only password generation).

@vinnyperella
Copy link

vinnyperella commented Nov 14, 2024

This was fixed by this PR, closing 🙂

@differsthecat This has not been fixed.

@Jan-Koll
Copy link
Author

In 2024.11.6 (19499) it is fixed.

@vinnyperella
Copy link

vinnyperella commented Jan 14, 2025

In 2024.11.6 (19499) it is fixed.

This still looks to be an issue in the Bitwarden native Android app 2025.1.0. Sometimes it lines up correctly but other times it does what I've shown below. Another issue was opened for this: #4394

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants