Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with AppConfig #12

Open
benjaoming opened this issue Feb 25, 2018 · 6 comments
Open

Problems with AppConfig #12

benjaoming opened this issue Feb 25, 2018 · 6 comments

Comments

@benjaoming
Copy link

benjaoming commented Feb 25, 2018

It seems that if an application is specified via AppConfig, it will not work:

INSTALLED_APPS = (
    'wiki.apps.WikiConfig'
)

For django-wiki, this produces errors like TemplateDoesNotExist: "wiki:wiki/base.html". Other variations like specifying the app config {% extends "wiki.apps.WikiConfig:wiki/base.html" %} aren't working neither.

Specified as just the app, it works:

INSTALLED_APPS = (
    'wiki'
)

I kind of gather from the implementation that it's assumed that the entry of INSTALLED_APPS is importable models and not AppConfig class paths?

https://github.com/bittner/django-apptemplates/blob/master/apptemplates/__init__.py#L18

@benjaoming
Copy link
Author

Just found out that this works fine with django-app-namespace-template-loader, and I'm good switching to that :)

@bittner
Copy link
Owner

bittner commented Feb 26, 2018

Thanks for the hint!

The issue seems to be identical to Fantomas42/django-app-namespace-template-loader#10.

@benjaoming
Copy link
Author

You can see the fix in the diffset between 0.3 and 0.3.1 where it was fixed: Fantomas42/django-app-namespace-template-loader@0.3...v0.3.1

@bittner
Copy link
Owner

bittner commented Mar 1, 2018

Do you want to try a PR?

@benjaoming
Copy link
Author

No, I switched to the other app -- remember Fantomas42/django-app-namespace-template-loader#15 ? ;)

@bittner
Copy link
Owner

bittner commented Mar 2, 2018

Just checking. Thanks for reporting, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants