Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x 128 bit hash instead of 2x 64 bit hash. Why? #78

Open
aratz-lasa opened this issue May 16, 2022 · 1 comment
Open

2x 128 bit hash instead of 2x 64 bit hash. Why? #78

aratz-lasa opened this issue May 16, 2022 · 1 comment

Comments

@aratz-lasa
Copy link

I noticed that for computing multiple hashes, you make use of the work of Less Hashing, Same Performance, which is calculated by: gi(x) = h1(x)+ih2(x) . For that you generate a 256 bits long hash partitioned into 4 uint64s. So I wonder why you decided to generate a 256 long hash partitioned into 4 uint64s. instead of 128 long hash partitioned into 2 uint64s 🤔 Wouldn't it be the same regarding hashing, but with a performance improvement?

@lemire
Copy link
Member

lemire commented Aug 18, 2022

Would you be willing to produce a pull request ? Note that we want to preserve backward compatibility so that the hash function is not allowed to change. However, if you have a more efficient implementation of the same hash function, we would love to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants