Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting level or pan/balance of LR in a matrix almost certainly doesn't work #58

Open
jswalden opened this issue Jun 8, 2024 · 1 comment
Assignees

Comments

@jswalden
Copy link
Collaborator

jswalden commented Jun 8, 2024

Going from code inspection, just as assigning LR to matrixes doesn't work (#34) because the parameter calculations mishandle LR being encoded as 99, I'm about 99% confident that changing pan/balance or level of LR within a matrix is broken for the same reason.

While I have a fix for LR-to-matrix assignment (gated behind various refactorings landing), I don't have one for these yet. setLevel and fadeLevel are two of the few stalls of this module's Augean stables that I haven't yet managed to clean up yet to the point where the code is intelligible to me. I might be able to fix the problem using techniques similar to what I used in #34, without having to understand them first, but I'm not sure.

@jswalden jswalden self-assigned this Jun 8, 2024
@jswalden
Copy link
Collaborator Author

I believe this is fixed as of 2578dc1 -- the point at which a final switch was made from the old busted fade-to-level implementation to a new one, invoked by different callers that correctly handle LR as source distinct from mixes as source.

No promises when a release with the fix will be made. I'm down to very, very little remaining cleanup left, tho, so it's somewhat likely "sooner" rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant