-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRAPI 1.5: update SmartAPI yamls for BTE + Service Provider #802
Comments
First step of creating the updated yamls is done in branch NCATS-Tangerine/translator-api-registry#149. It also changes BTE's workflow operation to lookup_and_score for #485 We'll do the next steps (including removing dev/CI server urls from the master ranch yamls) when we're ready to advertise that we do TRAPI 1.5 for dev/CI instances. |
To address the old questions/comments, I made minor changes to the current yamls (commit) and yamls on this branch (merge):
|
Small, not-important question for Jackson @tokebe: It's not clear to me if
If it's a custom request parameter, I could add it to our tool's yamls if I know what endpoints it works for / how it behaves. There seems to be some info in that PR |
Yes, we have a custom url query parameter that mimics the TRAPI-spec |
The tasks above are complete:
View in ARAX-UI's "SmartAPI info" tab (left column menu): Next steps: As TRAPI 1.5 is deployed to test/prod, we'll adjust the yamls/registrations. |
I've also updated the BTE/Service Provider yamls to add the log_level parameter (master branch, yamls on this branch). So I'm done following up on the old questions/comments. Yay! |
TRAPI 1.5 and other features were deployed to Test yesterday. So I've updated the yamls/registrations, moving the test instances to the temporary TRAPI 1.5 registrations (BTE, Service Provider). They use the branch PR yamls. I also changed the TRAPI version we advertise from "1.5.0-beta" -> "1.5.0". View in ARAX-UI's "SmartAPI info" tab (left column menu): |
Notes on next stepsWe may need to update the TRAPI 1.5 yamls when TRAPI 1.5 final (not beta) is released which should be at the end of this current sprint (Translator Slack link). When TRAPI 1.5 is released in Prod:
|
UpdateTRAPI 1.5.0 final was released today. I've updated the TRAPI 1.5 yamls with its minor updates (compare to TRAPI 1.5.0-beta). And refreshed the temporary registrations using these yamls. I've also updated the local docs/smartapi.yaml but I'm not sure if it's been deployed to CI. |
Update: sprint 2/Octopus has deployed to Prod. The registry updates are done and the chore issue's been updated with removing the SmartAPI exclusions
However, we have an update to the bte-server local copy (see previous comment). I've double-checked, and it's only been deployed on CI right now. There's also potential changes to this local copy, if we update the biolink-model version. I'd also like to do a cosmetic edit ("1.5.0" -> 1.5.0 for x-trapi.version) (also noted in #788 (comment)) |
Related commit deployed to Prod. |
The SmartAPI yamls for BTE + Service Provider are based on the TRAPI spec, so they'll need updating to TRAPI 1.5.
Let's wait until we've implemented the major + other minor features of TRAPI 1.5 in Dev/CI, then:
EDIT: did this additional piece - reviewing / addressing-if-still-relevant the old questions and comments from TRAPI 1.4 issue
The text was updated successfully, but these errors were encountered: