Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our tests fail to test workflows #6379

Closed
markotoplak opened this issue Mar 30, 2023 · 0 comments · Fixed by #6382
Closed

Our tests fail to test workflows #6379

markotoplak opened this issue Mar 30, 2023 · 0 comments · Fixed by #6382
Assignees
Labels
bug report Bug is reported by user, not yet confirmed by the core team

Comments

@markotoplak
Copy link
Member

...except the Qt6 tests.

#6181 had a compatibility issue which we almost did not catch because only Qt6 tests were having problems.

The cause for this is that tox.ini for testenv includes:

    # Skip loading of example workflows as that inflates coverage
    SKIP_EXAMPLE_WORKFLOWS=True

These worfklows should be skipped only for the run that is actually used for coverage. So we should do the opposite, run example workflows everywhere except on a one specific (coverage) run.

@markotoplak markotoplak added the bug report Bug is reported by user, not yet confirmed by the core team label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant