Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWTable crashes when loading a missing file with selected data #3451

Closed
pavlin-policar opened this issue Dec 7, 2018 · 0 comments
Closed
Assignees
Labels
bug A bug confirmed by the core team snack This will take an hour or two

Comments

@pavlin-policar
Copy link
Collaborator

Orange version

master

Issue

A similar issue to what is described in #3449. Loading a workflow where the source data file can no longer be found causes crashes. One would expect that in this case, None would be sent to inputs (just like removeing a widget signal on canvas), however it seems that this is not the case?

I've gone through most of the widgets in the Data and Visualize section and haven't been able to reproduce this bug, but it might be hiding in other widgets as well.

Traceback (most recent call last):
  File "/home/pavlin/dev/orange3/Orange/canvas/scheme/widgetsscheme.py", line 1073, in process_signals_for_widget
    handler(*args)
  File "/home/pavlin/dev/orange3/Orange/widgets/data/owtable.py", line 535, in set_dataset
    self.set_selection()
  File "/home/pavlin/dev/orange3/Orange/widgets/data/owtable.py", line 775, in set_selection
    model = view.model()
AttributeError: 'NoneType' object has no attribute 'model'

Steps to reproduce the behavior
  1. Open a workflow and connect File with some data to a Table, select some rows and save the workflow
  2. Remove/rename the data file in question so that the File widget can no longer find it
  3. Re-open the workflow in Orange → crash
@janezd janezd added the bug A bug confirmed by the core team label Jan 24, 2019
@janezd janezd added the snack This will take an hour or two label Feb 28, 2019
@rokgomiscek rokgomiscek self-assigned this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team snack This will take an hour or two
Projects
None yet
Development

No branches or pull requests

3 participants