Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual entry of proxy server. #1999

Closed
astaric opened this issue Feb 6, 2017 · 4 comments
Closed

Allow manual entry of proxy server. #1999

astaric opened this issue Feb 6, 2017 · 4 comments

Comments

@astaric
Copy link
Member

astaric commented Feb 6, 2017

On networks, where proxy use is mandatory, Orange cannot access the network.

We could add a setting to canvas where users could specify which proxy server to use and modify the widgets to access this setting and use proxy, if the setting has a value.

Addon dialog, file widget, image embedings (addon), twitter (addon) and some more need to be modified.

@kernc
Copy link
Contributor

kernc commented Mar 13, 2017

If we have the setting set http_proxy environment variable and require a restart, this is all that's needed for requests / urllib code to use it.

@astaric
Copy link
Member Author

astaric commented Mar 13, 2017

Set it when canvas is opened or did you have a more permanent way in mind? Why is the restart necessary?

@kernc
Copy link
Contributor

kernc commented Mar 13, 2017

Yes, when the canvas is open, check the setting and set the environ. The restart is necessary because any existing Request/Session objects wouldmight not honor this setting.

@astaric
Copy link
Member Author

astaric commented Mar 4, 2018

Fixed in #2906

@astaric astaric closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants