You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I thought we already had an issue for this, but apparently not!
Motivation: Lots of tree figures (e.g. Figure 1a in this paper I was reading) have a "gap" between between the start and end angle in the circular layout, which can look nice. In EMPress, we don't have this sort of gap by default, so the tree takes up an entire 360 degrees (or 2pi radians) of space:
Changing this when re-doing the circular layout is actually pretty simple -- we should only need to adjust one line:
Changing the numerator in this line from 2*pi to 1.9*pi gives us this:
...And just 1*pi, for reference:
This even works well with barplots out of the box:
It should be possible to add a UI element (ideally the sort of thing that is only visible when the circular layout is active) that adjusts this value -- I guess it would be most user-friendly to take inputs in degrees and then transform them to radians internally.
A solution to this issue would pair really well with #359, although the issues aren't necessarily dependent on each other or anything.
The text was updated successfully, but these errors were encountered:
We should impose a reasonable lower limit of maybe pi / 2 (90 degrees) or something similar -- it looks like length scaling gets messed up when setting the total angle span to pi / 10:
... Not sure what is causing this - likely weird precision stuff, and/or the approximations we use for circular layout barplots causing problems (#508).
This looks like a great addition. Adding a slider that only updates the layout when the selector is released would likely avoid freezing the UI when the trees are large. And perhaps including this as a sub-item to the "Circular" option in the layout tab, since I think this is a "layout" option.
I thought we already had an issue for this, but apparently not!
Motivation: Lots of tree figures (e.g. Figure 1a in this paper I was reading) have a "gap" between between the start and end angle in the circular layout, which can look nice. In EMPress, we don't have this sort of gap by default, so the tree takes up an entire 360 degrees (or 2pi radians) of space:
Changing this when re-doing the circular layout is actually pretty simple -- we should only need to adjust one line:
empress/empress/support_files/js/layouts-util.js
Line 561 in e543610
Changing the numerator in this line from 2*pi to 1.9*pi gives us this:
...And just 1*pi, for reference:
This even works well with barplots out of the box:
It should be possible to add a UI element (ideally the sort of thing that is only visible when the circular layout is active) that adjusts this value -- I guess it would be most user-friendly to take inputs in degrees and then transform them to radians internally.
A solution to this issue would pair really well with #359, although the issues aren't necessarily dependent on each other or anything.
The text was updated successfully, but these errors were encountered: