Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out type checking standards #43

Open
jsstevenson opened this issue Apr 2, 2024 · 1 comment
Open

Flesh out type checking standards #43

jsstevenson opened this issue Apr 2, 2024 · 1 comment
Labels
enhancement New feature or request keep alive exempt issue from staleness checks rfc Request for comments

Comments

@jsstevenson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
General brainstorming/thoughts on potential alterations to the type checking workflows defined here:

  • The example installs mypy-extension and pyright (if I remember correctly, the former doesn't really do anything for the latter, although I think Pylance can use it for type completions -- is that why it's there?). Should mypy be utilized as well?
  • The Makefile runs pyright as part of the cqa target, but it doesn't run in GitHub Actions. Should it?
  • As @korikuzma noticed, the tox file references some kind of types target, but doesn't seem to actually define or run it(?).
@jsstevenson jsstevenson added enhancement New feature or request rfc Request for comments labels Apr 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Jul 2, 2024
@korikuzma korikuzma removed the stale Issue is stale and subject to automatic closing label Jul 2, 2024
@jsstevenson jsstevenson added the keep alive exempt issue from staleness checks label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep alive exempt issue from staleness checks rfc Request for comments
Projects
None yet
Development

No branches or pull requests

2 participants