Instruction steps are strange #94
Comments
graue
added a commit
to bikehopper/bikehopper-ui
that referenced
this issue
Aug 6, 2022
Very basic version of showing bike infra in instructions. If between 25 and 50 percent of the step has an infra type, it's prefixed with "partial"; between 50 and 75, "mostly"; if over 75 percent we just say it's that infra type with no qualifier. Example: Turn right onto Cesar Chavez Street bike lane Turn left onto Guerrero Street mostly bike lane, partial protected bike lane Keep left on Arlington Street shared road In some cases these instructions are weird and would be more helpful if GraphHopper had split the instructions into segments differently. Filed an issue on GraphHopper repo: bikehopper/graphhopper#94 In the example described in that issue, BikeHopper will misleadingly tell you "Turn left onto Collingwood St / bike lane", even though there is no bike lane on Collingwood St, because the router is having you turn onto Market St (which has a bike lane) and counting that as the same instruction for some reason. Lots to iterate on and improve here, but I think this is a good start.
graue
added a commit
to bikehopper/bikehopper-ui
that referenced
this issue
Aug 19, 2022
Very basic version of showing bike infra in instructions. If between 25 and 50 percent of the step has an infra type, it's prefixed with "partial"; between 50 and 75, "mostly"; if over 75 percent we just say it's that infra type with no qualifier. Example: Turn right onto Cesar Chavez Street bike lane Turn left onto Guerrero Street mostly bike lane, partial protected bike lane Keep left on Arlington Street shared road In some cases these instructions are weird and would be more helpful if GraphHopper had split the instructions into segments differently. Filed an issue on GraphHopper repo: bikehopper/graphhopper#94 In the example described in that issue, BikeHopper will misleadingly tell you "Turn left onto Collingwood St / bike lane", even though there is no bike lane on Collingwood St, because the router is having you turn onto Market St (which has a bike lane) and counting that as the same instruction for some reason. Lots to iterate on and improve here, but I think this is a good start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed when routing from Eureka Valley Recreation Center to Fort Funston:
GraphHopper's returned instructions do NOT provide a "Keep [or turn] right on Market Street" instruction when you turn from Collingwood onto Market, but DO provide a "Keep right on Market Street" instruction further up where lanes shift slightly on Market Street
The text was updated successfully, but these errors were encountered: