Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very steep streets should still be preferred to lifting your bike up a staircase #120

Open
graue opened this issue May 12, 2023 · 0 comments
Assignees

Comments

@graue
Copy link

graue commented May 12, 2023

Pushing a bike on the sidewalk is easier than lifting it, so very steep streets should still be preferred to steps.

This route from Embarcadero Station to a one-block street called Calhoun Terrace is recommending lifting my bike up the Filbert Steps.

It is probably doing it because the only non-stair way up involves one block that's a 16%/17% grade according to HillMapper: Union from Kearny to Montgomery.

If I'm reading this right, a grade of 16% or higher has a penalty of REACH_DESTINATION, the highest value and the same value assigned to staircases, so it wouldn't be preferred over "schlep your bike up this enormous staircase."

return Math.max(REACH_DESTINATION.getValue(), p);

@steveliu397 steveliu397 self-assigned this Jun 17, 2024
graue added a commit that referenced this issue Jul 10, 2024
i.e. #120

Did not fix step usage in my two test cases

1. Noisebridge to Mount Sutro
2. Embarcadero Station to Calhoun Terrace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants