Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transit alert improvements #258

Open
1 of 3 tasks
graue opened this issue May 1, 2023 · 0 comments
Open
1 of 3 tasks

Transit alert improvements #258

graue opened this issue May 1, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@graue
Copy link
Contributor

graue commented May 1, 2023

Saw this alert on a test route and it made me think of 3 improvements that would be desirable:

image

  • These alerts are confusing because they don't explicitly say which bus stop the alert applies to. (One applies to the 18th & Valencia stop, one applies to the 18th & Guerrero stop). We should have a way to expand details and explicitly show the scope of the alert, in this case the stop it applies to.
  • These alerts are irrelevant to this trip because you don't board or alight at those stops. We should only show stop-specific alerts if you board or alight at, not just pass through, the stop. -> Only apply a stop-specific alert to legs that start or end at that stop bikehopper-web-app#23
  • The alerts look goofy because there's a colon floating in space, because Muni provided only body text and no header text. Should omit the colon if one of body/header text is blank.
@graue graue added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2024
@graue graue changed the title Alert improvements Transit alert improvements May 2, 2024
graue added a commit that referenced this issue Aug 22, 2024
This makes sure we don't show a colon unless there's both a header and a
body. Addresses part of #258
graue added a commit that referenced this issue Aug 22, 2024
This makes sure we don't show a colon unless there's both a header and a
body. Addresses part of #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant