Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

250 Howard St doesn't geocode #230

Open
graue opened this issue Jan 12, 2023 · 6 comments
Open

250 Howard St doesn't geocode #230

graue opened this issue Jan 12, 2023 · 6 comments
Labels
bug Something isn't working geocoding Related to location search/geocoding/location entry

Comments

@graue
Copy link
Contributor

graue commented Jan 12, 2023

We're unable to find 250 Howard St even though it works on OpenStreetMap.org's nominatim: https://www.openstreetmap.org/search?query=250%20howard%20st%2C%20san%20francisco#map=19/37.79044/-122.39377

This is different from #134 because it doesn't show even if you include the city, state and zip code. Why not?

@graue graue added bug Something isn't working geocoding Related to location search/geocoding/location entry labels Jan 12, 2023
@graue
Copy link
Contributor Author

graue commented Jan 12, 2023

The 250 Howard Street result on Nominatim is not a node, but a way:

     "properties" : {
        "category" : "place",
        "display_name" : "250, Howard Street, Transbay, San Francisco, CAL Fire Northern Region, California, 94105, United States",
        "importance" : -0.64,
        "osm_id" : 397148933,
        "osm_type" : "way",
        "place_id" : 315505950,
        "place_rank" : 30,
        "type" : "house"
     },

I don't know where it's getting the house number 250 from, since I don't see a 250 anywhere in the details for the "way". https://www.openstreetmap.org/way/397148933#map=17/37.78964/-122.39346

But this might not be the issue, since my home address also comes up as a "way" on OSM Nominatim, but works in BikeHopper.

@graue
Copy link
Contributor Author

graue commented Jan 20, 2023

1580 Valencia Street has the same problem (geocodes on OSM website, but not in Photon)

@graue
Copy link
Contributor Author

graue commented Jan 20, 2023

Still can't figure out where these address numbers (250 Howard or 1580 Valencia) are coming from, but my best hypothesis is that the address numbers are not stored in OSM itself, but are being added by Nominatim's TIGER support, and that Photon is somehow not using the Nominatim records that come from TIGER.

Meanwhile, we might want to explore using this: https://openaddresses.io/

@graue
Copy link
Contributor Author

graue commented Jan 20, 2023

I sent an email to the Photon mailing list about this

@graue
Copy link
Contributor Author

graue commented Jul 6, 2024

Could it be that adding TIGER support to our Nominatim instance would also fix Photon?

The public Nominatim instance can geocode this address, but not our Nominatim instance. Compare:

https://nominatim.openstreetmap.org/search?format=jsonv2&q=250+Howard+St,+San+Francisco,+California&limit=1 (good result)
https://bikehopper.org/api/v1/nominatim/search?format=jsonv2&q=250+Howard+St,+San+Francisco,+California&limit=1 (returns something irrelevant)

@Andykmcc
Copy link
Contributor

Andykmcc commented Jul 7, 2024

I setup TIGER the first time around 2+ years ago. I know it did it then. I had the rebuild our nominatim after the construction power outage at your place a bit ago. I used the same configs to recreate the DB but I didnt confirm if it imported TIGER this time around. I expected it to but maybe it didn't.

graue added a commit that referenced this issue Aug 27, 2024
Purpose: Mitigate bad geocoding like in issue #230 where typing an
address like "250 Howard Street" results in a generic result for just
"Howard Street."

How it works today: If you click on a geocoded result from the dropdown,
the input text gets replaced with a description of that geocoded result.
But if you type something and hit Return, your typed text stays
unchanged, giving no indication of what result was found.

What this commit changes: Typing something and hitting Return also
causes your input text to be replaced by a description of the geocoded
result.

Future work: Fix Photon not to return results at all if they fail to
match part of what you typed (or flag such results as inexact). Get
better address data into our geocoder.
graue added a commit that referenced this issue Aug 31, 2024
Purpose: Mitigate bad geocoding like in issue #230 where typing an
address like "250 Howard Street" results in a generic result for just
"Howard Street."

How it works today: If you click on a geocoded result from the dropdown,
the input text gets replaced with a description of that geocoded result.
But if you type something and hit Return, your typed text stays
unchanged, giving no indication of what result was found.

What this commit changes: Typing something and hitting Return also
causes your input text to be replaced by a description of the geocoded
result.

Future work: Fix Photon not to return results at all if they fail to
match part of what you typed (or flag such results as inexact). Get
better address data into our geocoder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geocoding Related to location search/geocoding/location entry
Projects
None yet
Development

No branches or pull requests

2 participants