Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #713 #727

Conversation

shamikbose
Copy link
Contributor

Passes all tests
No entries exist without "text" or "labels".
image

NOTE: This change applies to both "source" and "bigbio_text" schemas. If the "source" needs to remain unmodified, please let me know
Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

If the following information is NOT present in the issue, please populate:

  • Name: name of the dataset
  • Description: short description of the dataset (or link to social media or blog post)
  • Paper: link to the dataset paper if available
  • Data: link to the online home of the dataset

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Passes all tests
No entries exist without "text" or "labels".
@shamikbose
Copy link
Contributor Author

Only missing entries were in the "validation" split. Missing entries are in rows 34, 386, 391, 690, 897, 1100, 1518, 1682, 2157, 2311, 2473

@phlobo
Copy link
Collaborator

phlobo commented Jul 25, 2024

Hi @shamikbose! We are currently in the process of going through open issues and PRs and merging them whenever possible. Since you have a number of open PRs (thank you for that!), I wanted to ask you if you could possibly update them to the current contribution guide , i.e., making them compatible with the HF Hub.

If you don't have bandwidth for this, me and other maintainers would try to amend your PR by making the required changes ourselves, ideally still giving due credit to your contribution while doing that.

Please let me know what you think!

@phlobo phlobo self-assigned this Jul 25, 2024
@shamikbose
Copy link
Contributor Author

@phlobo I'm happy to take a look at the open PRs from my end on the weekend

phlobo added a commit to phlobo/biomedical that referenced this pull request Oct 21, 2024
@phlobo
Copy link
Collaborator

phlobo commented Oct 21, 2024

@shamikbose Thank you for your contribution!

I encountered various conflicts when trying to rebase this branch with the main repo, therefore I had to open a new PR with your changes: #949

@phlobo phlobo closed this Oct 21, 2024
mariosaenger pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants